Right now we don't use in-tree mozconfigs for release builds, but once we merge from central to aurora and beta for Firefox 10 we'll be able to. Probably bug 558180 is where that will happen (*sets dependency*). release_sanity will then need to learn to look at the in-tree mozconfigs to do the comparisons. This is a followup to bug 386338 (*sets blocking*).

taking this and changed it to depending on bug 386338 since we needed release_sanity to check mozconfigs at all before we can ask it to check for in-tree or not (as that will be for some branches and not all like mozilla-1.9.2)

This caused an error in the 10.0esr release because we don't have buildbot-configs versions of the mozconfigs at all. Any ETA on this?

Testing out this fix in staging: diff --git a/buildbot-helpers/release_sanity.py b/buildbot-helpers/release_sanity.py index 300094b..f40eced 100644 --- a/buildbot-helpers/release_sanity.py +++ b/buildbot-helpers/release_sanity.py @@ -110,7 +110,7 @@ def verify_mozconfigs(branch, version, hghost, product, platforms, whitelist=Non urls = [] mozconfigs = [] for type in types.values(): - urls.append(make_hg_url(hghost, 'build/buildbot-configs', 'http', + urls.append(make_hg_url(hghost, branch, 'http', tag, os.path.join('mozilla2', platform, branch, type,'mozconfig'))) for url in urls:

I'm working on a fix for this as part of bug 717106, which suffers from this more acutely.

This affects ESR more than other branches, because we don't have a full set of mozconfigs in buildbot-configs. Because of that, I had to find a fix.

Comment on attachment 593287 [details] [diff] [review] use mozconfigs from release config to find in-repo ones to compare lgtm, thanks for picking this up

Fennec is a good citizen as well :) PYTHONPATH=. python ../tools/buildbot-helpers/release_sanity.py -u rail -pfirefox,fennec -V 10.0b1 --branch mozilla-beta --build-number 1 -c release-firefox-mozilla-beta.py -c release-fennec-mozilla-beta.py --dryrun localhost:9001 2>&1 | tee rail.out (build1)[cltbld@buildbot-master08 master]$ PYTHONPATH=. python ../tools/buildbot-helpers/release_sanity.py -u rail -pfirefox,fennec \ > -V 11.0b1 --branch mozilla-beta --build-number 1 -c release-firefox-mozilla-beta.py -c release-fennec-mozilla-beta.py \ > --dryrun localhost:9001 2>&1 | tee rail.out Traceback (most recent call last): File "../tools/buildbot-helpers/release_sanity.py", line 365, in <module> releaseConfig['sourceRepositories']['mozilla']['path'], KeyError: 'mozilla'