Closed Bug 697636 Opened 13 years ago Closed 13 years ago

requestFullScreen should not work on navigated-away documents

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: jruderman, Assigned: cpearce)

References

Details

(Keywords: assertion, testcase, Whiteboard: [sg:low?][inbound])

Attachments

(3 files, 1 obsolete file)

Attached file testcase (deleted) —
== Steps == 1. Set these prefs: user_pref("full-screen-api.allow-trusted-requests-only", false); user_pref("full-screen-api.enabled", true); 2. Load the testcase. == Result == 1. Firefox enters full-screen mode. 2. ###!!! ASSERTION: Document should report fullscreen: 'fullscreen', file content/html/content/src/nsGenericHTMLElement.cpp, line 3413 3. ###!!! ASSERTION: Should be in full screen state!: 'doc->IsFullScreenDoc()', file content/html/content/src/nsGenericHTMLElement.cpp, line 3414 == Expected == 1. The requestFullScreen call should throw. == Security impact == This might be bypass for lack of mozallowfullscreen attribute.
Attached file assertion stacks (deleted) —
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
I'll reopen this bug and resolve it separately from bug 685402 to simplify patches, reviews, and landings.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Attached patch Patch v1 (obsolete) (deleted) — Splinter Review
Patch, with Jesse's testcase. Based on top of bug 688648 and bug 685779, so will hold of on requesting review until they're reviewed.
Assignee: nobody → chris
Status: REOPENED → ASSIGNED
Attached patch Patch v2 (deleted) — Splinter Review
Rebased on top of patch in bug 685779 and bug 688468. Includes test.
Attachment #570173 - Attachment is obsolete: true
Attachment #570855 - Flags: review?(bzbarsky)
Comment on attachment 570855 [details] [diff] [review] Patch v2 r=me
Attachment #570855 - Flags: review?(bzbarsky) → review+
OS: Mac OS X → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla10
Whiteboard: [sg:low?] → [sg:low?][inbound]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago13 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: