David Baron :dbaron: Reporter
	Description • 13 years ago

I did a try push with the try chooser syntax:

try: --build do --platform win32 --unittests mochitest-1,mochitest-2,mochitest-3,mochitest-4,mochitest-5 --talos none 

which https://wiki.mozilla.org/Build:TryChooser says ought to give me windows mochitests.  However, I got only builds (debug and opt on Windows), and no tests were run:

https://tbpl.mozilla.org/?tree=Try&rev=1f107262cc0c

I'm not sure if it was the platform line or the unittests line that caused no tests to run, but something is wrong with either the trychooser code or its documentation.

	Phil Ringnalda (:philor)
	Comment 1 • 13 years ago

Probably nothing at all to do with syntax, and instead to do with bug 697802.

	David Baron :dbaron: Reporter
	Comment 2 • 13 years ago

Same problem with:
https://tbpl.mozilla.org/?tree=Try&rev=42d3729cc5e9
where I used the syntax:
try: --build do --platform win32 --unittests all --talos none

	Armen [:armenzg]
	Comment 4 • 13 years ago

dbaron both commits are lacking the syntax you mention:
https://hg.mozilla.org/try/rev/1f107262cc0c
https://hg.mozilla.org/try/rev/42d3729cc5e9

I believe the try parser has trouble with multiple lines in a comment.
I mean. It has the syntax but it is really at the end of a not standard multi-line comment:

'''
Disable try platforms that I don't want.

See https://wiki.mozilla.org/Build:TryChooser for full syntax. Summary is:

-b --build TYPE
Choose what type of builds you'd like made:
--build d gives debug builds only
--build o gives optimized builds only
--build do gives both debug and optimized builds

-p --platform LIST
Choose which platform(s) you'd like to build for with a
comma-separated list:
linux,linux64,macosx,macosx64,win32,maemo5-qt,android-r7,maemo5-gtk
or specify 'none' or 'all'.

-u --unittests LIST
Choose which unittests you'd like run:
crashtest,reftest,mochitests
or give a subset of tests:
mochitest-{1,2,3,4,5,o},xpcshell,opengl,jsreftest,mozmill-all
or specify 'none' or 'all'.

-t --talos LIST
Choose which talos suites you'd like to run:
tp,tscroll,tspider,etc.
or specify 'none' or 'all'.

Email notification control: (these are optional, default is to get emails on non-success)

-e --all-emails (optional)
Get notified by email of each builder in the try run's results

-n --no-emails (optional)
Get no email notifications of each builder's results

Bugzilla commenting:

--post-to-bugzilla Bug BUGNUMBER (optional)
Get a comment in your specified BUGNUMBER at the end of the try run with a tally of the results and a tbpl link


try: --build do --platform win32 --unittests mochitest-1,mochitest-2,mochitest-3,mochitest-4,mochitest-5 --talos none
'''

	David Baron :dbaron: Reporter
	Comment 5 • 13 years ago

The try parser is fine with the syntax done that way; it's worked many times.  The "try: " bit is on the last line.

	David Baron :dbaron: Reporter
	Comment 6 • 13 years ago

(I'd note that it reported on the command line that the parse was successful, and it did win32 builds only, as requested.)

	Nick Thomas [:nthomas] (UTC+12)
	Comment 7 • 13 years ago

I'm pretty sure that bug 697802 is the cause here. The try parser is OK with multiline comments, but the bit of code which notifies buildbot to schedule tests for a windows build is not.