bug 674250 got Microsoft's binscope tool installed on the build slaves bug 642243 relates to integrating binscope runs into windows builds via make check calling a python script - as part of the review process for the python script, it was modified to look for binscope.exe in a directory pointed to by the BINSCOPE environment variable - binscope gets installed by default to different Program Files dirs depending on whether it's on a 32 or 64 version of Windows and using an env variable seems to give RelEng the most flexibility as well. this bug is about setting the BINSCOPE variable on windows build slaves to point to the directory where binscope is installed. when this is done, i can do a try run for 642243 again and then hopefully land it :)

ted pointed out in the final review of bug 642243 that BINSCOPE can just as well point to the actual binscope.exe file as well (ie. BINSCOPE="c:\Program Files\Microsoft\SDL Binscope\binscope.exe" instead of BINSCOPE="c:\Program Files\Microsoft\SDL Binscope\" i'm fine with either of these, i'll make sure the script is accurate after the env variable lands on the build slaves :)

Comment on attachment 574054 [details] [diff] [review] Add BINSCOPE env var to win32, win32-debug, and win32-mobile https://hg.mozilla.org/build/buildbot-configs/rev/aadf83ba55d4

This landed in this morning's reconfig.

will this take some time to propagate everywhere ? i just did a try run of 642243 and got make[3]: Leaving directory `/e/builds/moz2_slave/try-w32/build/obj-firefox/build/win32/crashinjectdll' d:/mozilla-build/python25/python2.5.exe /e/builds/moz2_slave/try-w32/build/build/win32/autobinscope.py ../../dist/bin/firefox.exe ../../dist/crashreporter-symbols/ BINSCOPE environment variable is not set, can't check DEP/ASLR etc. status. d:/mozilla-build/python25/python2.5.exe /e/builds/moz2_slave/try-w32/build/build/win32/autobinscope.py ../../dist/bin/plugin-container.exe ../../dist/crashreporter-symbols/ BINSCOPE environment variable is not set, can't check DEP/ASLR etc. status. (this was on mw32-ix-slave16)

(In reply to Ian Melven :imelven from comment #5) > will this take some time to propagate everywhere ? No, it should be active everywhere. Only the try leak test builds are picking up the env var for some reason.

We override try win32 ENV in http://mxr.mozilla.org/build/source/buildbot-configs/mozilla/production_config.py#165 I don't know the reason behind that top of my head (nor did I bother to research it right now)

Just for completeness, I verified that m-c is currently specifying BINSCOPE. https://tbpl.mozilla.org/php/getParsedLog.php?id=7464883&tree=Firefox

(In reply to Justin Wood (:Callek) from comment #7) > We override try win32 ENV in > http://mxr.mozilla.org/build/source/buildbot-configs/mozilla/ > production_config.py#165 Thanks, Callek. Patch incoming.

Comment on attachment 575436 [details] [diff] [review] Add BINSCOPE env var to win32 on try https://hg.mozilla.org/build/buildbot-configs/rev/1dca9f9a63a9

Reconfig is done. BINSCOPE should be available on try now.

(In reply to Chris Cooper [:coop] from comment #12) > Reconfig is done. BINSCOPE should be available on try now. Thanks very much ! I'll give bug 642243 another try (pun intended) later today.