Closed
Bug 700902
Opened 13 years ago
Closed 13 years ago
balrog's client.wsgi app shouldn't try to create database tables
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
References
Details
Attachments
(1 file)
(deleted),
patch
|
catlee
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
The client app is meant to be run with read-only access to the database, and attempting to create the tables is probably causing the app to throw an Exception. We'll also need to figure out what _should_ be creating the tables. The two obvious options are the admin app (admin.wsgi) and some separate script that gets run by hand on request.
Assignee | ||
Comment 1•13 years ago
|
||
I gave this a quick run through locally against sqlite and mysql, both worked fine.
Attachment #573497 -
Flags: review?(catlee)
Comment 2•13 years ago
|
||
Comment on attachment 573497 [details] [diff] [review]
make table creation explicit, disable it in client.wsgi; add manage-db.py script
Review of attachment 573497 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, as long as we fix up the naming of AUS-server.py / client.wsgi eventually
Attachment #573497 -
Flags: review?(catlee) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Comment on attachment 573497 [details] [diff] [review]
make table creation explicit, disable it in client.wsgi; add manage-db.py script
Landed, and passed on Jenkins: https://jenkins.mozilla.org/job/Balrog/31/
Attachment #573497 -
Flags: checked-in+
Assignee | ||
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•