Closed Bug 711995 Opened 13 years ago Closed 2 years ago

Favicons should be imported from Chrome

Categories

(Firefox :: Migration, enhancement)

Product:
Firefox
Component:
Migration
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
113 Branch
Tracking Flags:
Tracking Status
relnote-firefox --- 113+
firefox109 --- wontfix
firefox113 --- verified

People

(Reporter: virgil.dicu, Assigned: rmacoy)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Bug 711995 - Favicons should be imported from Chrome.
(deleted), text/x-phabricator-request
Details
Mozilla/5.0 (X11; Linux x86_64; rv:11.0a1) Gecko/20111208 Firefox/11.0a1 STR: 1. Erase or modify the Firefox folder. 2. Start Firefox. 3. Import from Chrome. Actual result: favicons of bookmark and history pages are displayed with default favicon unless loading the respective pages. Favicons are loaded correctly when importing in Chrome from Firefox.
Blocks: 505192
We need access Favions sqlite file on importing. sqlite> .schema favicons CREATE TABLE favicons(id INTEGER PRIMARY KEY,url LONGVARCHAR NOT NULL,last_updat ed INTEGER DEFAULT 0,image_data BLOB,icon_type INTEGER DEFAULT 1, sizes LONGVARC HAR); CREATE INDEX favicons_url ON favicons(url);
See bug 326701 for the same enhancement request for the safari migrator.
Severity: normal → enhancement

Hi,

I could repro this issue on Nightly 77.0a1 Windows 10.

Regards,

Blocks: calstate
Summary: Favicons are not loaded for imported Chrome bookmark pages → Favicons should be imported from Chrome
Assignee: nobody → r.bryan.macoy
Severity: normal → S3

This issue is also reproducible for import from Opera/Vivaldi browser on MacOS 11.6 and Win 10 using Nightly 109.0a1.

Attachment #9304016 - Attachment description: WIP: Bug 711995 - Favicons should be imported from Chrome. R?mconley. → Bug 711995 - Favicons should be imported from Chrome. R?mconley.
Attachment #9304016 - Attachment description: Bug 711995 - Favicons should be imported from Chrome. R?mconley. → WIP: Bug 711995 - Favicons should be imported from Chrome. R?mconley.
Attachment #9314602 - Attachment is obsolete: true
Attachment #9304016 - Attachment description: WIP: Bug 711995 - Favicons should be imported from Chrome. R?mconley. → Bug 711995 - Favicons should be imported from Chrome. R?mconley.
Attachment #9304016 - Attachment description: Bug 711995 - Favicons should be imported from Chrome. R?mconley. → WIP: Bug 711995 - Favicons should be imported from Chrome. R?mconley.
Attachment #9304016 - Attachment description: WIP: Bug 711995 - Favicons should be imported from Chrome. R?mconley. → Bug 711995 - Favicons should be imported from Chrome. R?mconley.
Attachment #9304016 - Attachment description: Bug 711995 - Favicons should be imported from Chrome. R?mconley. → WIP: Bug 711995 - Favicons should be imported from Chrome. R?mconley.
Attachment #9304016 - Attachment description: WIP: Bug 711995 - Favicons should be imported from Chrome. R?mconley. → Bug 711995 - Favicons should be imported from Chrome. R?mconley.
Attachment #9304016 - Attachment description: Bug 711995 - Favicons should be imported from Chrome. R?mconley. → Bug 711995 - Favicons should be imported from Chrome.
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/695609b39bd2 Favicons should be imported from Chrome. r=mconley

https://hg.mozilla.org/mozilla-central/rev/695609b39bd2

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox113: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch

Did we want to call this and bug 326701 out in the Fx113 relnotes? Please nominate if so :)

status-firefox109: affected → wontfix
Flags: needinfo?(mconley)

Release Note Request (optional, but appreciated)
[Why is this notable]:

Users that import from a Chrome-based browser will find that most of their bookmark favicons should appear, rather than being the default globe favicon.

This is similar to bug 326701, which adds favicon import support to Safari.

[Affects Firefox for Android]:

No.

[Suggested wording]:

Importing bookmarks from Safari or a Chrome-based browser? The favicons for those bookmarks will now also be imported by default to make them easier to identify.

[Links (documentation, blog post, etc)]:

None.

relnote-firefox: --- → ?
Flags: needinfo?(mconley)
Duplicate of this bug: 1789769

Added to the 113 Nightly relnotes, thanks!

relnote-firefox: ? → 113+

Verified as part of QA-1784 that user bookmarks and favicons from Chrome-based browsers are successfully imported into Firefox Nightly 113.0a1 on the following operating systems and browsers:

  • Windows 10x64: Edge, Edge Beta, Chrome, Chrome Beta, Chrome Canary, Chromium, Brave, Opera, OperaGX, Vivaldi, and 360 Secure Browser
  • macOS 12: Edge, Edge Beta, Chrome, Chrome Canary, Chromium, Brave, Opera, OperaGX, and Vivaldi
  • Ubuntu 20.04: Chrome, Chrome Dev, Chromium, Chrome Beta, Brave, Opera, Vivaldi.

During testing, we encountered bug 1825239 (S3) which is not considered a blocker for this implementation. More details can be found in Testrail Report.
We will leave this open until verification is performed on Firefox 113 beta as well.

Verified as part of QA-1784 that user bookmarks and favicons from Chrome-based browsers are successfully imported into Firefox Beta 113.0bx on the following operating systems and browsers:

  • Windows 11x64: Edge, Edge Beta, Chrome, Chrome Beta, Chrome Canary, Chromium, Brave, Opera, OperaGX, Vivaldi, and 360 Secure Browser
  • macOS 12 arm: Edge, Edge Beta, Chrome, Chrome Canary, Chromium, Brave, Opera, OperaGX, and Vivaldi
  • Ubuntu 22.04: Chrome, Chrome Dev, Chromium, Chrome Beta, Brave, Opera, Vivaldi.

Only bug 1825239 (S3) was encountered during testing. More details can be found in Testrail Report.

Status: RESOLVED → VERIFIED
status-firefox113: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: