Closed
Bug 725488
Opened 13 years ago
Closed 12 years ago
in Junk Settings, disable junk target folder pickers based on the radio selector (Junk on/Other), similarly to pickers on Copies & Folders
Categories
(MailNews Core :: Account Manager, defect)
MailNews Core
Account Manager
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 18.0
People
(Reporter: aceman, Assigned: aceman)
References
(Blocks 2 open bugs)
Details
(Keywords: polish, ux-consistency)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
In the Junk settings pane of Account manager, the folders for moving of junk mails are only disabled when the moving of junk is disabled with the checkbox.
The individual folder pickers (Junk on <thisaccount> and Other ) could be disabled depending on the radio button selecting them.
As it is done in Copies & Folders (Sent, Archive, Drafts, Templates target groups).
Summary: disable junk target folder pickers based on the radio selector, similarly to pickers on Copies & Folders → in Junk Settings, disable junk target folder pickers based on the radio selector (Junk on/Other), similarly to pickers on Copies & Folders
Attachment #663848 -
Flags: ui-review?(bwinton)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 663848 [details] [diff] [review]
patch
Yep, this seems nicer, too. ui-r=me!
Thanks,
Blake.
Attachment #663848 -
Flags: ui-review?(bwinton) → ui-review+
Attachment #663848 -
Flags: review?(mconley)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 663848 [details] [diff] [review]
patch
Review of attachment 663848 [details] [diff] [review]:
-----------------------------------------------------------------
Just one comment about the documentation. Other than that, I think I'm OK with this.
Thanks aceman!
::: mailnews/base/prefs/content/am-junk.js
@@ +206,5 @@
> + updateJunkRetention();
> +}
> +
> +/**
> + * Enable/disable the folder picker for the selected radio item.
I think this comment is misleading - it makes me think that I can use this function to enable or disable the folder picker by passing some arguments.
In actuality, it's just syncing the state of some items with some other items.
@@ +215,5 @@
> +}
> +
> +/**
> + * Enable/disable the junk deletion interval.
> + */
Same as above.
Attachment #663848 -
Flags: review?(mconley) → review+
Thanks, done.
Attachment #663848 -
Attachment is obsolete: true
Attachment #665127 -
Flags: review?(iann_bugzilla)
Attachment #665127 -
Flags: review?(iann_bugzilla) → review+
Keywords: checkin-needed
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
You need to log in
before you can comment on or make changes to this bug.
Description
•