Closed
Bug 725897
Opened 13 years ago
Closed 13 years ago
Remove the inaccurate nsSVGUtils::ToAppPixelRect, and use nsLayoutUtils::RoundGfxRectToAppRect instead
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
longsonr
:
review+
|
Details | Diff | Splinter Review |
nsSVGUtils::ToAppPixelRect rounds CSS px before scaling them, which means we get inaccurate results. Unfortunately we have tests that contain off numbers to compensate, but these inaccuracies are exaggerated even further by the kill-covered-regions patches in bug 614732, causing those tests to fail with those patches.
In principle nsSVGUtils::ToAppPixelRect duplicates nsLayoutUtils::RoundGfxRectToAppRect, and the latter rounds properly making it more accurate. Switching to RoundGfxRectToAppRect gets me part way to solving the failures that occur with the kill-covered-regions patches in bug 614732.
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Comment 2•13 years ago
|
||
Passed Try.
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 595918 [details] [diff] [review]
patch
Actually, there's no reason to put this in roc's path (I was just in "it's display list stuff" mode).
Attachment #595918 -
Flags: review?(roc) → review?(longsonr)
|
||
Updated•13 years ago
|
Attachment #595918 -
Flags: review?(longsonr) → review+
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•