Closed
Bug 725903
Opened 13 years ago
Closed 13 years ago
PathExtentsToMaxStrokeExtents needs to take a transform argument
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
longsonr
:
review+
|
Details | Diff | Splinter Review |
PathExtentsToMaxStrokeExtents currently just uses GetCanvasTM() to figure out how much to expand the stroke by. When calling GetBBoxContribution, this can mean that we get the expansion very wrong, since the transform to the canvas is not usually what we want.
The kill-covered-regions patches in bug 614732 switch to using GetBBoxContribution in user space (instead of canvas space) as part of figuring out the covered region, and some tests fail as a result of PathExtentsToMaxStrokeExtents using the canvas TM.
|
Assignee | |
Comment 1•13 years ago
|
||
This patch also depends on the changes to test_bounds.html in bug 725897.
Attachment #595925 -
Flags: review?(roc)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Passed Try.
|
|
Assignee | |
Updated•13 years ago
|
Attachment #595925 -
Flags: review?(roc) → review?(longsonr)
|
||
Updated•13 years ago
|
Attachment #595925 -
Flags: review?(longsonr) → review+
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•