http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1329533748.1329538419.29635.gz WINNT 5.2 comm-central-trunk debug test mochitest-other on 2012/02/17 18:55:48 { TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/toolkit/components/viewsource/test/browser/browser_viewsourceprefs.js | Test timed out TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/toolkit/components/viewsource/test/browser/browser_viewsourceprefs.js | Found unexpected view source window still open }

This test does not (seem to) actually depend on 'about:robots', does it? This change lets this test succeed on SeaMonkey.

Comment on attachment 598602 [details] [diff] [review] (Av1) browser_viewsourceprefs.js: Use "about:mozilla", instead of "about:robots", to support non-Firefox applications [Checked in: Comments 3 and 6] Looks fine to me. I can't review this though, so I've forwarded the review to Neil Rashbrook.

Comment on attachment 598602 [details] [diff] [review] (Av1) browser_viewsourceprefs.js: Use "about:mozilla", instead of "about:robots", to support non-Firefox applications [Checked in: Comments 3 and 6] https://hg.mozilla.org/mozilla-central/rev/7df4ef4a3a58 [Approval Request Comment] Regression caused by (bug #): Bug 702448. User impact if declined: None, but perma-orange (with timeout) on SeaMonkey. Testing completed (on m-c, etc.): This comment. Risk to taking this patch (and alternatives if risky): None, test only. String changes made by this patch: None.

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1329822596.1329827961.29626.gz OS X 10.6 comm-central-trunk debug test mochitest-other on 2012/02/21 03:09:56 V.Fixed

Comment on attachment 598602 [details] [diff] [review] (Av1) browser_viewsourceprefs.js: Use "about:mozilla", instead of "about:robots", to support non-Firefox applications [Checked in: Comments 3 and 6] [Triage Comment] Test only fix - approved for Aurora 12 and Beta 11.

Comment on attachment 598602 [details] [diff] [review] (Av1) browser_viewsourceprefs.js: Use "about:mozilla", instead of "about:robots", to support non-Firefox applications [Checked in: Comments 3 and 6] http://hg.mozilla.org/releases/mozilla-aurora/rev/fdc6d9d791d7 http://hg.mozilla.org/releases/mozilla-beta/rev/2c04d3e4a9ed

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Aurora/1329891487.1329895867.22195.gz OS X 10.6 comm-aurora debug test mochitest-other on 2012/02/21 22:18:07 firefox12: verified. *** firefox11: SM log didn't report this failure. (Don't care further, atm.)

If "firefox11: SM log didn't report this as a failure", why was approval-mozilla-beta requested?

(In reply to Jared Wein [:jaws] from comment #8) > If "firefox11: SM log didn't report this as a failure", why was > approval-mozilla-beta requested? In short: "broken" log should not prevent test fix.

(In reply to Serge Gautherie (:sgautherie) from comment #7) > firefox11: SM log didn't report this failure. (Don't care further, atm.) (SM log is now fixed.) http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Beta/1330246820.1330252359.8062.gz&fulltext=1 Linux comm-beta debug test mochitest-other on 2012/02/26 01:00:20 { INFO TEST-END | chrome://mochitests/content/browser/toolkit/components/viewsource/test/browser/browser_viewsourceprefs.js | finished in 3525ms } firefox11: verified.