Closed
Bug 728626
Opened 13 years ago
Closed 12 years ago
(non-)Firefox tests should not use 'about:robots' which is Firefox specific
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla15
People
(Reporter: sgautherie, Assigned: raymondlee)
References
()
Details
(Whiteboard: [meta])
Attachments
(1 file, 3 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review |
Take SeaMonkey as an example:
*Core tests are perma-orange.
*Firefox tests are harder to port.
Comment 1•13 years ago
|
||
I think I'll pass on this one. I've got a full plate right now, and I'm not focusing in this area -- mark
Reporter | ||
Updated•13 years ago
|
Whiteboard: [meta] → [good first bug][mentor=sgautherie][lang=js] [meta]
Assignee | ||
Comment 2•12 years ago
|
||
I have updated those robots config in http://mxr.mozilla.org/comm-central/search?string=about%3Arobots&case=1&find=test, except the below:
/mozilla/browser/components/tabview/test/browser_tabview_bug610242.js
line 32 -- let robots = win.gBrowser.loadOneTab("about:robots", bg);
line 82 -- check(robots, "about:robots", true);
This test requires a "about:" page with icon and I couldn't find a about page with icon in seamonkey. I can either that check in the test or leave it as it is. What do you think?
Reporter | ||
Comment 3•12 years ago
|
||
(In reply to Raymond Lee [:raymondlee] from comment #2)
> /mozilla/browser/components/tabview/test/browser_tabview_bug610242.js
>
> This test requires a "about:" page with icon and I couldn't find a about
> page with icon in seamonkey.
An 'about:*' page with a favicon?
From SM 2.12a1 about:about, it looks like there is 4 of them:
about:addons ("but" inner content tries to access services.addons.mozilla.org :-/)
about:data (but it is SeaMonkey specific :-()
about:sync-log
about:sync-tabs
And there is more of them, like about:sessionrestore.
Could you try to use one of these?
Reporter | ||
Comment 4•12 years ago
|
||
Comment on attachment 620608 [details] [diff] [review]
v1
Review of attachment 620608 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/base/content/test/browser_tabMatchesInAwesomebar.js
@@ +133,5 @@
> gBrowser.removeTab(tabToKeep);
> ensure_opentabs_match_db(nextStep);
> });
> }, true);
> + tab.linkedBrowser.loadURI('about:mozilla');
Nit: while here, use '"'.
::: browser/components/privatebrowsing/test/browser/browser_privatebrowsing_zoom.js
@@ +60,4 @@
>
> + let mozillaBrowser = gBrowser.getBrowserForTab(tabMozilla);
> + mozillaBrowser.addEventListener("load", function () {
> + mozillaBrowser.removeEventListener("load", arguments.callee, true);
Nit: while here, give the listener a name instead of using arguments.callee.
::: browser/components/tabview/test/browser_tabview_bug586553.js
@@ +23,5 @@
>
> contentWindow = document.getElementById("tab-view").contentWindow;
>
> originalTab = gBrowser.selectedTab;
> + newTabs = [gBrowser.addTab("about:cache"), gBrowser.addTab("about:mozilla"), gBrowser.addTab("about:license")];
Nit: fine, yet is there any reason to choose about:cache rather than a more usual page like about:[rights] or the like?
::: browser/components/tabview/test/browser_tabview_bug650573.js
@@ +83,2 @@
> let tab1 = {
> + entries: [{url: "about:cache"}],
Nit: fine, yet is there any reason to choose about:cache rather than a more usual page like about:[rights] or the like?
Attachment #620608 -
Flags: review?(sgautherie.bz) → feedback+
Assignee | ||
Comment 5•12 years ago
|
||
Attachment #620608 -
Attachment is obsolete: true
Attachment #625637 -
Flags: review?(sgautherie.bz)
Reporter | ||
Comment 6•12 years ago
|
||
Comment on attachment 625637 [details] [diff] [review]
v2
Review of attachment 625637 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/components/tabview/test/browser_tabview_bug586553.js
@@ +28,3 @@
>
> is(originalTab._tPos, 0, "Original tab is in position 0");
> + is(newTabs[0]._tPos, 1, "Cache is in position 1");
s/Cache/Rights/
@@ +50,5 @@
> is(moves, 1, "Only one move should be necessary for this basic move.");
>
> is(newTabs[2]._tPos, 0, "License is in position 0");
> is(originalTab._tPos, 1, "Original tab is in position 1");
> + is(newTabs[0]._tPos, 2, "Cache is in position 2");
s/Cache/Rights/
Attachment #625637 -
Flags: review?(sgautherie.bz) → feedback+
Assignee | ||
Comment 7•12 years ago
|
||
Attachment #625637 -
Attachment is obsolete: true
Attachment #625848 -
Flags: review?
Assignee | ||
Updated•12 years ago
|
Attachment #625848 -
Flags: review? → review?(sgautherie.bz)
Reporter | ||
Updated•12 years ago
|
Attachment #625848 -
Flags: review?(ttaubert)
Attachment #625848 -
Flags: review?(sgautherie.bz)
Attachment #625848 -
Flags: feedback+
Updated•12 years ago
|
Attachment #625848 -
Flags: review?(ttaubert) → review+
Reporter | ||
Comment 8•12 years ago
|
||
Comment on attachment 625848 [details] [diff] [review]
v3
>Bug 728626 - (non-)Firefox tests should not use 'about:robots' which is Firefox specific try: -m none -u mochitest-o
Remove " try: -m none -u mochitest-o".
Assignee | ||
Comment 9•12 years ago
|
||
Attachment #625848 -
Attachment is obsolete: true
Assignee | ||
Updated•12 years ago
|
Attachment #626044 -
Attachment is patch: true
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 10•12 years ago
|
||
Comment 11•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 12•12 years ago
|
||
V.Fixed, per MXR search.
Status: RESOLVED → VERIFIED
Whiteboard: [good first bug][mentor=sgautherie][lang=js] [meta] → [meta]
You need to log in
before you can comment on or make changes to this bug.
Description
•