http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1329731717.1329737218.9616.gz&fulltext=1 WINNT 5.2 comm-central-trunk debug test xpcshell on 2012/02/20 01:55:17 { TEST-INFO | e:\builds\slave\test\build\xpcshell\tests\toolkit\components\places\tests\autocomplete\test_tabmatches.js | running test ... TEST-PASS | e:\builds\slave\test\build\xpcshell\tests\toolkit\components\places\tests\autocomplete\test_tabmatches.js | test passed (time: 1766.000ms) } This test passes nonetheless, but better use 'about:mozilla' for example.

I'm asking for feedback from all, eventual review+ from :mak77 for this small patch. I ran a successful build locally, and after review+ I plan to test on TRY by autolanding with -b do -p android,android-xul -u all -t none. Let me know if there's another way to test, or pre-requisites I've missed, etc.

Comment on attachment 600441 [details] [diff] [review] Patch (v1) Fwiw, that's what I expected.

Comment on attachment 600441 [details] [diff] [review] Patch (v1) Review of attachment 600441 [details] [diff] [review]: ----------------------------------------------------------------- assuming you ran the test and it passes, I don't see any problem with the change

Autoland Patchset: Patches: 600441 Branch: mozilla-central => try Destination: http://hg.mozilla.org/try/pushloghtml?changeset=ee371fdeaa44 Try run started, revision ee371fdeaa44. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=ee371fdeaa44

Try run for ee371fdeaa44 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=ee371fdeaa44 Results (out of 43 total builds): success: 37 warnings: 6 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-ee371fdeaa44

Curious ... TRYing again

Autoland Patchset: Patches: 600441 Branch: mozilla-central => try Destination: http://hg.mozilla.org/try/pushloghtml?changeset=5ab26007f95f Try run started, revision 5ab26007f95f. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=5ab26007f95f

Try run for 5ab26007f95f is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=5ab26007f95f Results (out of 42 total builds): exception: 1 success: 34 warnings: 5 failure: 2 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-5ab26007f95f

https://hg.mozilla.org/integration/mozilla-inbound/rev/44241c8e5132 Your patch required fixing to import properly into hg. Please make sure you follow the guidelines below before posting your next patch. https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Not sure what part I'm missing in the patch ... are you looking for changeset information? Does this require that I use merqurial queues ? please specify or I'll ask on IRQ ...

Yeah, I think the missing changeset information is what messed it up. Originally, it ended up using me as the user and making your # User entry the title of the patch. Give mq a try, it's very handy anyway :)

Ah.... ok :-P I managed it once or twice but got lost when I started working on multiple patches simultaneously ... I'll go for it again. And thanks -- mark

(In reply to Ryan VanderMeulen from comment #11) > Originally, it ended up using me as the user and making your # User entry > the title of the patch. Give mq a try, it's very handy anyway :) You can use 'From: ' instead of '# User '. Anyway, mq is great.

V.Fixed, as still succeeding on Firefox and SeaMonkey.