Closed
Bug 728999
Opened 13 years ago
Closed 13 years ago
browser_526613.js should not use 'about:robots' which is Firefox specific
Categories
(Firefox :: Session Restore, defect, P3)
Firefox
Session Restore
Tracking
()
VERIFIED
FIXED
Firefox 13
People
(Reporter: sgautherie, Assigned: sgautherie)
References
()
Details
Attachments
(1 file)
This test passes nonetheless, but better use 'about:mozilla' for example.
****
Ftr, to be checked afterward,
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1329768128.1329772780.9739.gz&fulltext=1
WINNT 5.2 comm-central-trunk debug test mochitest-other on 2012/02/20 12:02:08
{
...
TEST-PASS | chrome://mochitests/content/browser/suite/common/tests/browser/browser_526613.js | Restoring the old state should have left this window open
************************************************************
* Call to xpconnect wrapped JSObject produced this error: *
[Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIURI.equals]" nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)" location: "JS frame :: chrome://communicator/content/viewZoomOverlay.js :: <TOP_LEVEL> :: line 238" data: no]
************************************************************
************************************************************
* Call to xpconnect wrapped JSObject produced this error: *
[Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIURI.equals]" nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)" location: "JS frame :: chrome://communicator/content/viewZoomOverlay.js :: <TOP_LEVEL> :: line 238" data: no]
************************************************************
************************************************************
* Call to xpconnect wrapped JSObject produced this error: *
[Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIURI.equals]" nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)" location: "JS frame :: chrome://communicator/content/viewZoomOverlay.js :: <TOP_LEVEL> :: line 238" data: no]
************************************************************
************************************************************
* Call to xpconnect wrapped JSObject produced this error: *
[Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIURI.equals]" nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)" location: "JS frame :: chrome://communicator/content/viewZoomOverlay.js :: <TOP_LEVEL> :: line 238" data: no]
************************************************************
INFO TEST-END | chrome://mochitests/content/browser/suite/common/tests/browser/browser_526613.js | finished in 3275ms
TEST-INFO | chrome://mochitests/content/browser/suite/common/tests/browser/browser_526613.js | Console message: [JavaScript Error: "[Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIURI.equals]" nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)" location: "JS frame :: chrome://communicator/content/viewZoomOverlay.js :: <TOP_LEVEL> :: line 238" data: no]" {file: "chrome://communicator/content/viewZoomOverlay.js" line: 238}]
TEST-INFO | chrome://mochitests/content/browser/suite/common/tests/browser/browser_526613.js | Console message: [JavaScript Error: "[Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIURI.equals]" nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)" location: "JS frame :: chrome://communicator/content/viewZoomOverlay.js :: <TOP_LEVEL> :: line 238" data: no]" {file: "chrome://communicator/content/viewZoomOverlay.js" line: 238}]
TEST-INFO | chrome://mochitests/content/browser/suite/common/tests/browser/browser_526613.js | Console message: [JavaScript Error: "[Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIURI.equals]" nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)" location: "JS frame :: chrome://communicator/content/viewZoomOverlay.js :: <TOP_LEVEL> :: line 238" data: no]" {file: "chrome://communicator/content/viewZoomOverlay.js" line: 238}]
TEST-INFO | chrome://mochitests/content/browser/suite/common/tests/browser/browser_526613.js | Console message: [JavaScript Error: "[Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIURI.equals]" nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)" location: "JS frame :: chrome://communicator/content/viewZoomOverlay.js :: <TOP_LEVEL> :: line 238" data: no]" {file: "chrome://communicator/content/viewZoomOverlay.js" line: 238}]
}
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #599039 -
Flags: review?(ehsan)
Comment 2•13 years ago
|
||
Comment on attachment 599039 [details] [diff] [review]
(Av1) browser_526613.js: Use "about:mozilla", instead of "about:robots", to support non-Firefox applications
[Checked in: Comment 3]
Review of attachment 599039 [details] [diff] [review]:
-----------------------------------------------------------------
It's in m-c/browser/ so it's by definition a Firefox test, right? Since SS changes are always ported, I assumed the tests were as well, in which case it should be fixed in comm-central...
The change is fine but it's entirely likely that there will be more tests that don't run in Seamonkey...
Attachment #599039 -
Flags: review?(ehsan) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Comment on attachment 599039 [details] [diff] [review]
(Av1) browser_526613.js: Use "about:mozilla", instead of "about:robots", to support non-Firefox applications
[Checked in: Comment 3]
https://hg.mozilla.org/mozilla-central/rev/246bc1c98175
(In reply to Paul O'Shannessy [:zpao] from comment #2)
> It's in m-c/browser/ so it's by definition a Firefox test, right? Since SS
Obviously.
> changes are always ported, I assumed the tests were as well, in which case
> it should be fixed in comm-central...
Bug 729000.
> The change is fine but it's entirely likely that there will be more tests
> that don't run in Seamonkey...
Bug 728626.
Attachment #599039 -
Attachment description: (Av1) browser_526613.js: Use "about:mozilla", instead of "about:robots", to support non-Firefox applications → (Av1) browser_526613.js: Use "about:mozilla", instead of "about:robots", to support non-Firefox applications
[Checked in: Comment 3]
Assignee | ||
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Comment 4•13 years ago
|
||
(In reply to Serge Gautherie (:sgautherie) from comment #3)
> (In reply to Paul O'Shannessy [:zpao] from comment #2)
> > It's in m-c/browser/ so it's by definition a Firefox test, right? Since SS
>
> Obviously.
My point here is that there isn't really a reason to fix this in m-c and if a test isn't working in comm-central, the fix really belongs there.
Assignee | ||
Comment 5•13 years ago
|
||
(In reply to Paul O'Shannessy [:zpao] from comment #4)
> My point here is that there isn't really a reason to fix this in m-c and if
> a test isn't working in comm-central, the fix really belongs there.
The reason is to reduce differences. Why use specific resources when not required?
Assignee | ||
Updated•13 years ago
|
Comment 6•13 years ago
|
||
(In reply to Serge Gautherie (:sgautherie) from comment #5)
> (In reply to Paul O'Shannessy [:zpao] from comment #4)
> > My point here is that there isn't really a reason to fix this in m-c and if
> > a test isn't working in comm-central, the fix really belongs there.
>
> The reason is to reduce differences. Why use specific resources when not
> required?
The whole service is specific to Firefox. I'm fine taking the changes but I don't agree with the mentality that we should think about Seamonkey when writing Firefox tests. Compatibility with Seamonkey should be handled by whomever is doing the porting.
Assignee | ||
Comment 7•13 years ago
|
||
(In reply to Paul O'Shannessy [:zpao] from comment #6)
> The whole service is specific to Firefox. I'm fine taking the changes but I
> don't agree with the mentality that we should think about Seamonkey when
Sad :-|
> writing Firefox tests. Compatibility with Seamonkey should be handled by
> whomever is doing the porting.
Isn't that what I'm working on?
Assignee | ||
Comment 8•13 years ago
|
||
V.Fixed, as 'mochitest-browser-chrome' still succeed.
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 9•13 years ago
|
||
(In reply to Serge Gautherie (:sgautherie) from comment #0)
> Ftr, to be checked afterward,
Done in bug 729000 comment 4.
You need to log in
before you can comment on or make changes to this bug.
Description
•