Closed Bug 733490 Opened 13 years ago Closed 11 years ago

Run v8 on try

Categories

(Release Engineering :: General, defect, P4)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: justin.lebar+bug, Unassigned)

References

Details

(Whiteboard: [tryserver])

We run v8 on mozilla-inbound, but there's no way to force it on try.

This means that if I regress v8 on inbound (as I did in bug 729940), there's no way for me to test whether I fixed it without pushing to m-i.  (In bug 729940, I also regressed Dromaeo jslib, but only on Windows, while the v8 regression was on Linux as well, so finding the regression using Dromaeo will be much slower than using v8.)

If there's a good reason not to run v8 on try, I wonder why we're running it on m-i?
Component: Release Engineering → Release Engineering: Developer Tools
QA Contact: release → lsblakk
Whiteboard: [tryserver]
Why are we running this on m-i and not m-c?
Priority: -- → P4
Because we ran it only on the TraceMonkey tree, because js hackers wanted to know the effect of their patches on it but didn't feel the need to have it run against every single non-js/src/ push, and then mozilla-inbound became the new TraceMonkey.
(In reply to Phil Ringnalda (:philor) from comment #2)
> Because we ran it only on the TraceMonkey tree, because js hackers wanted to
> know the effect of their patches on it but didn't feel the need to have it
> run against every single non-js/src/ push, and then mozilla-inbound became
> the new TraceMonkey.

And the missing piece is that JS hackers used TM like try (was my understanding).  But we don't use m-i like try.
Do we want this enabled everywhere? or just m-i and try?
> But we don't use m-i like try.

Or at least, that's not sanctioned... :)

(In reply to Armen Zambrano G. [:armenzg] - Release Engineer from comment #4)
> Do we want this enabled everywhere? or just m-i and try?

I kind of feel like we should run it everywhere, if we think it's a good benchmark, or nowhere, if we don't.  But so long as it's on try, I'm happy.
Depends on: 767226
QA Contact: lsblakk → hwine
currently now we have v8 (version 7) in the dromaeojs suite.  This just landed today and it runs on all platforms.  I am looking to disable the old v8 for trunk based branches in bug 781290.
Product: mozilla.org → Release Engineering
Fixed by bug 781290, long ago.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Component: Tools → General
You need to log in before you can comment on or make changes to this bug.