Closed
Bug 73436
Opened 24 years ago
Closed 23 years ago
npspy/common should not use win32api calls
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Future
People
(Reporter: timeless, Assigned: serhunt)
References
()
Details
Attachments
(1 file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
at least, it would seem to me that the common directory should be for common
functions and not platform specific functions.
/modules/plugin/npspy/common/npp_gate.cpp, line 79 -- NP_GETENTRYPOINTS
real_NP_GetEntryPoints = (NP_GETENTRYPOINTS)GetProcAddress(hLib,
"NP_GetEntryPoints");
This is a good catch. I overlooked it. Thanks. Will take care.
|
||
Updated•24 years ago
|
Target Milestone: --- → Future
|
|
||
Comment 3•23 years ago
|
||
r=peterl
Checked in.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You're still including windowsx.h (which i suspect is windows related) and
there's one other windowsism in logger.cpp (neither are wrapped in XP_WIN). --
I can file new bugs if you want.
verified fixed + filed
Bugzilla Bug 96245 Including <windowsx.h> even for non windows platforms
Status: RESOLVED → VERIFIED
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•