Closed
Bug 76602
Opened 24 years ago
Closed 23 years ago
mozilla/modules/plugin folder needs revising
Categories
(SeaMonkey :: Build Config, defect, P2)
SeaMonkey
Build Config
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.4
People
(Reporter: serhunt, Assigned: leaf)
References
Details
Attachments
(6 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
application/octet-stream
|
Details | |
(deleted),
application/octet-stream
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
text/plain
|
Details |
mozilla/modules/plugin is currently kind of messy. It has been suggested that we probably shouldn't make any additions to it before we bring it to some order. I have new samples to check in as well as bugs in the spy tool, some stuff I just moved from 0.9 so it is pretty urgent, and thus would really like to have the issue resolved. Here is the current structure: plugins/ | +---- bad/ +---- default/ +---- macbuild/ +---- mpdk/ +---- nglsrc/ +---- npspy/ +---- public/ +---- SanePlugin/ +---- test/ +---- testevents/ After a discussion via e-mail with some of the people on the cc list we came up with the following layout which will supposedly make everyone happy: plugins | +---- base/ | +---- public/ | +---- src/ (currently ``nglsrc/'') | +---- macbuild/ | +---- samples/ | +---- default/ | +---- SanePlugin/ | +---- simple/ (currently ``test/'') | +---- testevents/ | +---- backward/ (currently ``bad/'') | +---- 4x-scriptable/ (this one is impatiently waiting) | +---- tools +---- mpdk/ +---- spy/ (currently ``npspy/'') Assigning to myself but expect somebody from the build team at least give me detailed instructions.
Setting dependencies.
Assignee | ||
Comment 2•24 years ago
|
||
targetting for 0.9.1, av, i'll have to do some repository copies to make this happen and keep history (which, i assume, you care about).
Target Milestone: --- → mozilla0.9.1
This is great. Thanks, leaf. Does it mean we should imply a 'freeze' between you back it up and the new layout checked in?
Assignee | ||
Comment 4•24 years ago
|
||
a freeze would be nice, i'll try and do this by the end of this week, 0.9 is my priority. would a freeze that long be too painful?
Status: NEW → ASSIGNED
Comment 6•24 years ago
|
||
Jonathan/Leaf, can this make mozilla0.9.1? The code being blocked to check-in looks like it can help lots of embedding partners and plugin developers.
Keywords: mozilla0.9.1
leaf, I reassigning this to you as we agreed in prior e-mail exchange.
Assignee: av → leaf
Status: ASSIGNED → NEW
Assignee | ||
Comment 10•24 years ago
|
||
do i need to worry about people doing work in those dirs right now?
Assignee: leaf → leaf
Status: ASSIGNED → NEW
Assignee | ||
Comment 11•24 years ago
|
||
also, i need mac help to get it building in the new location before we do any cvs removals of old stuff.
Status: NEW → ASSIGNED
Comment 12•24 years ago
|
||
chances are that if peter and andrei aren't mucking around in there, nobody is, but i'm cc'ing beard (who does Mac plugin stuff on occasion, but only LiveConnect -- also, he can maybe help you with this) and shaver (who may nose around in there trying to tidy up an otherwise ugly story).
Assignee | ||
Comment 13•24 years ago
|
||
alright, i've done the copy. makefile cleanup to follow (and i still need mac help), and then we can do cvs removal of the old file locations.
Assignee | ||
Comment 14•23 years ago
|
||
Comment 15•23 years ago
|
||
Comment 16•23 years ago
|
||
Comment 17•23 years ago
|
||
Updated•23 years ago
|
Target Milestone: mozilla0.9.3 → mozilla0.9.4
Assignee | ||
Comment 18•23 years ago
|
||
Comment 21•23 years ago
|
||
Unless there is a really good reason for keeping it around please kill the pluginClassic.mcp project (and it's associated files.) Other than that, the mac changes look ok. r=bnesse.
Comment 22•23 years ago
|
||
No, please don't nuke pluginClassic.mcp. This is provided to run legacy, pre- carbon plugins when the Carbon build is running on Mac OS 9.
Comment 23•23 years ago
|
||
I made the changes to pluginClassic.mcp anyway not realizing that the project is missing from the build script anyway. I'll keep my changes and won't nuke the files as it can't hurt. Simon, can I get your super revie
Updated•23 years ago
|
Priority: -- → P2
Reporter | ||
Comment 28•23 years ago
|
||
Any news on completing this bug? Leaf, are you going to synchronize the content of the current two structures when you make final changes to the makefiles?
Assignee | ||
Comment 29•23 years ago
|
||
i had a tree mishap today; i have a tree again and i'm doublechecking that the build works, i'll commit when my build finishes.
Assignee | ||
Comment 31•23 years ago
|
||
Comment 32•23 years ago
|
||
looks fine to me, I nuked all those anyway while testing my build script changes. r=peterl
Reporter | ||
Comment 34•23 years ago
|
||
leaf, what is ./fad folder? Also, I noticed ./pdk60 directory. Is it what was supposed to be ./tools/mpdk? ./src also seems to be a ghost to me.
Assignee | ||
Comment 35•23 years ago
|
||
if you do: cvs co mozilla/modules/plugin without -P, you get all the empty directories that are under plugin, so in my careless manual cvs operations, i pulled them and they got sucked into my list of directories to remove.
Assignee | ||
Comment 36•23 years ago
|
||
cvs removal finally committed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•