The Permissions table in db.py currently checks permissions. We already check permissions at the web layer. To be consistent with other Tables, we should *only* check for permissions at the web layer.

Remove permissions checking for modification of the permissions table. The assumption is that the permissions will be checked on the web ui side.

Comment on attachment 605949 [details] [diff] [review] Remove permissions checking in db.py Review of attachment 605949 [details] [diff] [review]: ----------------------------------------------------------------- It looks like there's some references left to these methods in the tests, can you remove them too? You can use a simple "make test" command in the root of the repository to run the tests.

Patch still applies cleanly.

Comment on attachment 606198 [details] [diff] [review] Update patch to remove tests for removed code I landed this patch along with bug 733478, and the first Jenkins run burned with: ====================================================================== FAIL: testAddRelease (auslib.test.test_db.TestReleases) ---------------------------------------------------------------------- Traceback (most recent call last): File "/var/lib/jenkins/jobs/Balrog/workspace/auslib/test/test_db.py", line 458, in testAddRelease self.assertEquals(self.releases.t.select().where(self.releases.name=='d').execute().fetchall(), expected) AssertionError: [] != [('d', 'd', 'd', '{"name": 4}', 1)] -------------------- >> begin captured logging << -------------------- auslib.db: DEBUG: AUSTable._prepareInsert: Executing query: 'INSERT INTO releases (name, product, version, data, data_version) VALUES (?, ?, ?, ?, ?)' with values: {'data_version': 1, 'product': 'd', 'version': 'd', 'data': '{"name": 4}', 'name': 'd'} auslib.db: DEBUG: History.getTimestamp: returning 1332533253657 --------------------- >> end captured logging << --------------------- I can't repro locally, or on Jenkins, so I left it. However, I'd like to dig into it some more...I don't like having random orange :(.

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=738773 to track the intermittent orange.