Closed
Bug 737556
Opened 13 years ago
Closed 12 years ago
extra email notification sent for fennec "all signed builds available"
Categories
(Release Engineering :: Release Automation: Other, defect, P3)
Release Engineering
Release Automation: Other
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: catlee, Assigned: bhearsum)
Details
Attachments
(2 files)
(deleted),
patch
|
bhearsum
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
rail
:
review+
mozilla
:
checked-in+
|
Details | Diff | Splinter Review |
For Firefox 12.0b1 we got an email extra notification once signing was done. The subject was also incorrect:
"[release] Fennec 11.0b5 build1: All signed builds now available"
Reporter | ||
Comment 1•13 years ago
|
||
according to the email headers, the extra notification was sent from dev-master01, so I'm guessing somebody's staging instance is at fault here.
Comment 2•13 years ago
|
||
We should set the following staging variables to nobody@example.com or just [].
releaseConfig['AllRecipients'] = ['nobody@example.com',]
releaseConfig['ImportantRecipients'] = ['nobody@example.com',]
releaseConfig['AVVendorsRecipients'] = ['nobody@example.com',]
Assignee | ||
Comment 3•13 years ago
|
||
Bulk move of bugs to Release Automation component.
Component: Release Engineering: Automation (General) → Release Engineering: Automation (Release Automation)
Assignee | ||
Comment 4•13 years ago
|
||
Mass move of bugs to Release Automation component.
Assignee | ||
Updated•13 years ago
|
No longer blocks: hg-automation
Assignee | ||
Comment 5•12 years ago
|
||
This sounds like the result of someone's staging master being set-up incorrectly...
Assignee | ||
Comment 6•12 years ago
|
||
(In reply to Rail Aliiev [:rail] from comment #2)
> We should set the following staging variables to nobody@example.com or just
> [].
>
> releaseConfig['AllRecipients'] = ['nobody@example.com',]
> releaseConfig['ImportantRecipients'] = ['nobody@example.com',]
> releaseConfig['AVVendorsRecipients'] = ['nobody@example.com',]
This is easy, let's do this.
Assignee: nobody → bhearsum
Comment 7•12 years ago
|
||
Attachment #668994 -
Flags: review?(bhearsum)
Comment 8•12 years ago
|
||
Comment on attachment 668994 [details] [diff] [review]
nobody
wouldn't this give us twistd errors because of returned mail? if I am right can we have a XYZ@mozilla.com that auto-deletes or something [like spam@mozilla.com] instead?
Assignee | ||
Comment 9•12 years ago
|
||
(In reply to Justin Wood (:Callek) from comment #8)
> Comment on attachment 668994 [details] [diff] [review]
> nobody
>
> wouldn't this give us twistd errors because of returned mail? if I am right
> can we have a XYZ@mozilla.com that auto-deletes or something [like
> spam@mozilla.com] instead?
If you're running your own staging release you should update these to point at only yourself. Preproduction automatically overrides in: https://github.com/mozilla/build-buildbot-configs/blob/master/mozilla/preproduction_release_overrides.py
The point here is to prevent accidentally spamming the entire group with your staging release results.
Assignee | ||
Updated•12 years ago
|
Attachment #668994 -
Flags: review?(bhearsum) → review+
Comment 10•12 years ago
|
||
(In reply to Ben Hearsum [:bhearsum] from comment #9)
> If you're running your own staging release you should update these to point
> at only yourself.
Yeah. I didn't want to set it to None to even block staging reconfig without local modifications. :)
Comment 11•12 years ago
|
||
Comment on attachment 668994 [details] [diff] [review]
nobody
http://hg.mozilla.org/build/buildbot-configs/rev/dbc3cf1daa48
Attachment #668994 -
Flags: checked-in+
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 12•12 years ago
|
||
(In reply to Ben Hearsum [:bhearsum] from comment #9)
> The point here is to prevent accidentally spamming the entire group with
> your staging release results.
I think this patch failed in that regard.
Comment 13•12 years ago
|
||
(In reply to Aki Sasaki [:aki] from comment #12)
> (In reply to Ben Hearsum [:bhearsum] from comment #9)
> > The point here is to prevent accidentally spamming the entire group with
> > your staging release results.
>
> I think this patch failed in that regard.
I 100% agree.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 14•12 years ago
|
||
Simple fix would be to change the "sender" on the mailnotifiers. Can't do that easily just for staging, not sure if we'd want to do it for production.
Comment 15•12 years ago
|
||
Attachment #671519 -
Flags: review?(rail)
Updated•12 years ago
|
Attachment #671519 -
Flags: review?(rail) → review+
Comment 16•12 years ago
|
||
Comment on attachment 671519 [details] [diff] [review]
stop spamming
http://hg.mozilla.org/build/buildbot-configs/rev/eb5bf5bad2ed
Attachment #671519 -
Flags: checked-in+
Updated•12 years ago
|
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•