Closed Bug 737556 Opened 13 years ago Closed 12 years ago

extra email notification sent for fennec "all signed builds available"

Categories

(Release Engineering :: Release Automation: Other, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: catlee, Assigned: bhearsum)

Details

Attachments

(2 files)

For Firefox 12.0b1 we got an email extra notification once signing was done. The subject was also incorrect: "[release] Fennec 11.0b5 build1: All signed builds now available"
according to the email headers, the extra notification was sent from dev-master01, so I'm guessing somebody's staging instance is at fault here.
We should set the following staging variables to nobody@example.com or just []. releaseConfig['AllRecipients'] = ['nobody@example.com',] releaseConfig['ImportantRecipients'] = ['nobody@example.com',] releaseConfig['AVVendorsRecipients'] = ['nobody@example.com',]
Bulk move of bugs to Release Automation component.
Component: Release Engineering: Automation (General) → Release Engineering: Automation (Release Automation)
Mass move of bugs to Release Automation component.
No longer blocks: hg-automation
This sounds like the result of someone's staging master being set-up incorrectly...
(In reply to Rail Aliiev [:rail] from comment #2) > We should set the following staging variables to nobody@example.com or just > []. > > releaseConfig['AllRecipients'] = ['nobody@example.com',] > releaseConfig['ImportantRecipients'] = ['nobody@example.com',] > releaseConfig['AVVendorsRecipients'] = ['nobody@example.com',] This is easy, let's do this.
Assignee: nobody → bhearsum
Attached patch nobody (deleted) — Splinter Review
Attachment #668994 - Flags: review?(bhearsum)
Comment on attachment 668994 [details] [diff] [review] nobody wouldn't this give us twistd errors because of returned mail? if I am right can we have a XYZ@mozilla.com that auto-deletes or something [like spam@mozilla.com] instead?
(In reply to Justin Wood (:Callek) from comment #8) > Comment on attachment 668994 [details] [diff] [review] > nobody > > wouldn't this give us twistd errors because of returned mail? if I am right > can we have a XYZ@mozilla.com that auto-deletes or something [like > spam@mozilla.com] instead? If you're running your own staging release you should update these to point at only yourself. Preproduction automatically overrides in: https://github.com/mozilla/build-buildbot-configs/blob/master/mozilla/preproduction_release_overrides.py The point here is to prevent accidentally spamming the entire group with your staging release results.
Attachment #668994 - Flags: review?(bhearsum) → review+
(In reply to Ben Hearsum [:bhearsum] from comment #9) > If you're running your own staging release you should update these to point > at only yourself. Yeah. I didn't want to set it to None to even block staging reconfig without local modifications. :)
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
(In reply to Ben Hearsum [:bhearsum] from comment #9) > The point here is to prevent accidentally spamming the entire group with > your staging release results. I think this patch failed in that regard.
(In reply to Aki Sasaki [:aki] from comment #12) > (In reply to Ben Hearsum [:bhearsum] from comment #9) > > The point here is to prevent accidentally spamming the entire group with > > your staging release results. > > I think this patch failed in that regard. I 100% agree.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Simple fix would be to change the "sender" on the mailnotifiers. Can't do that easily just for staging, not sure if we'd want to do it for production.
Attached patch stop spamming (deleted) — Splinter Review
Attachment #671519 - Flags: review?(rail)
Attachment #671519 - Flags: review?(rail) → review+
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: