Closed
Bug 737632
Opened 13 years ago
Closed 9 years ago
Make sure that we only add as many builders as strictly necessary
Categories
(Release Engineering :: General, defect, P3)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: armenzg, Unassigned)
Details
Attachments
(4 files, 1 obsolete file)
(deleted),
patch
|
armenzg
:
feedback-
|
Details | Diff | Splinter Review |
(deleted),
patch
|
coop
:
review+
armenzg
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
I have seen few cases on mozilla-tests/config.py and mozilla/project_branches.py
I will hopefully make it make more sense.
This is necessary as I have few more suites to add and I am hitting the 1024 limit.
Reporter | ||
Comment 1•13 years ago
|
||
This is my first pass.
I will try to get in touch with project owners and update their requirements as some branches like jaegermonkey are abandoned.
Attachment #608480 -
Flags: review?(aki)
Comment 2•13 years ago
|
||
I'm not entirely sure what you're trying to do here, so I'm going to wait til you're back to verify. It does look like you want to explicitly list what's in each project branch, which I approve of. It's hard to figure out what our current programmatic config is doing.
In the meantime, I've run dump_masters to see what the net effect here will be.
First, run dump_masters to get clean output:
~/src/clean/braindump/buildbot-related/dump_masters.sh 2>&1 >../clean.dump
Then hg import and get patched output:
hg import --no-commit ~/Desktop/less_builders.v4.diff
~/src/clean/braindump/buildbot-related/dump_masters.sh 2>&1 >../armen.dump
Try to only get the information of changed builders:
egrep '^[><] [a-zA-Z]' factory.diff >x
Separate added and removed factory entries:
grep '^>' x | sed -e 's/^> \(.*\)$/\1/'| sort | uniq >added
grep '^<' x | sed -e 's/^< \(.*\)$/\1/'| sort | uniq >removed
Get a summary of added/removed builders:
diff -U0 removed added > summary
Looks like we're removed 890 builders, which is great. Does this list look correct?
Attachment #608536 -
Flags: feedback?(armenzg)
Comment 3•13 years ago
|
||
Hm, I got factory diff via
diff ../{clean,armen}.dump | grep -i factory > ../factory.diff
which I'm not sure is accurate, but then I doublechecked:
diff clean.dump armen.dump | egrep '^[><] [a-zA-Z]' > X
diff x X
They're the same. I think the above file is still accurate.
Comment 4•13 years ago
|
||
see also bug 737661 where we have jetpack testers for platforms we don't build
Reporter | ||
Comment 5•13 years ago
|
||
Comment on attachment 608536 [details] [diff] [review]
diff off removed/added builders
Thanks for taking the time.
I think my eyes were getting tired and just focusing on few branches.
I will have an updated patch in few hours.
BTW I use builder_list.py from braindump.py and comment out few lines to only output the build names.
Attachment #608536 -
Flags: feedback?(armenzg) → feedback-
Updated•13 years ago
|
Attachment #608480 -
Flags: review?(aki)
Reporter | ||
Comment 6•13 years ago
|
||
I will reach project owners for "graphics" and "jaegermonkey".
I would like to remove "Pine" from the available lists and add it when extremely necessary.
Reporter | ||
Comment 7•13 years ago
|
||
I see "birch" (unused branch) as 'birch': {}, but I see all of these builders:
Android birch build
Android Debug birch build
Android XUL birch build
Linux birch build
Linux birch leak test build
Linux x86-64 birch build
Linux x86-64 birch leak test build
Linux QT birch build
OS X 10.5.2 birch leak test build
OS X 10.6.2 birch build
OS X 10.6.2 birch leak test build
WINNT 5.2 birch build
WINNT 5.2 birch leak test build
WINNT 6.1 x86-64 birch build
These are just from the Windows testers:
Rev3 WINNT 5.1 birch talos nochrome.2
Rev3 WINNT 5.1 birch talos chrome.2
Rev3 WINNT 5.1 birch talos dromaeo
Rev3 WINNT 5.1 birch talos svg
Rev3 WINNT 5.1 birch talos tpr_responsiveness
Rev3 WINNT 5.1 birch talos dirty
Rev3 WINNT 5.1 birch opt test mochitests-1/5
Rev3 WINNT 5.1 birch opt test mochitests-2/5
Rev3 WINNT 5.1 birch opt test mochitests-3/5
Rev3 WINNT 5.1 birch opt test mochitests-4/5
Rev3 WINNT 5.1 birch opt test mochitests-5/5
Rev3 WINNT 5.1 birch opt test mochitest-other
Rev3 WINNT 5.1 birch opt test reftest
Rev3 WINNT 5.1 birch opt test crashtest
Rev3 WINNT 5.1 birch opt test xpcshell
Rev3 WINNT 5.1 birch opt test jsreftest
Rev3 WINNT 5.1 birch debug test mochitests-1/5
Rev3 WINNT 5.1 birch debug test mochitests-2/5
Rev3 WINNT 5.1 birch debug test mochitests-3/5
Rev3 WINNT 5.1 birch debug test mochitests-4/5
Rev3 WINNT 5.1 birch debug test mochitests-5/5
Rev3 WINNT 5.1 birch debug test mochitest-other
Rev3 WINNT 5.1 birch debug test reftest
Rev3 WINNT 5.1 birch debug test crashtest
Rev3 WINNT 5.1 birch debug test xpcshell
Rev3 WINNT 5.1 birch debug test jsreftest
Rev3 WINNT 6.1 birch talos nochrome.2
Rev3 WINNT 6.1 birch talos chrome.2
Rev3 WINNT 6.1 birch talos dromaeo
Rev3 WINNT 6.1 birch talos svg
Rev3 WINNT 6.1 birch talos tpr_responsiveness
Rev3 WINNT 6.1 birch talos dirty
Rev3 WINNT 6.1 birch opt test mochitests-1/5
Rev3 WINNT 6.1 birch opt test mochitests-2/5
Rev3 WINNT 6.1 birch opt test mochitests-3/5
Rev3 WINNT 6.1 birch opt test mochitests-4/5
Rev3 WINNT 6.1 birch opt test mochitests-5/5
Rev3 WINNT 6.1 birch opt test mochitest-other
Rev3 WINNT 6.1 birch opt test reftest
Rev3 WINNT 6.1 birch opt test crashtest
Rev3 WINNT 6.1 birch opt test xpcshell
Rev3 WINNT 6.1 birch opt test jsreftest
Rev3 WINNT 6.1 birch opt test reftest-no-accel
Rev3 WINNT 6.1 birch debug test mochitests-1/5
Rev3 WINNT 6.1 birch debug test mochitests-2/5
Rev3 WINNT 6.1 birch debug test mochitests-3/5
Rev3 WINNT 6.1 birch debug test mochitests-4/5
Rev3 WINNT 6.1 birch debug test mochitests-5/5
Rev3 WINNT 6.1 birch debug test mochitest-other
Rev3 WINNT 6.1 birch debug test reftest
Rev3 WINNT 6.1 birch debug test crashtest
Rev3 WINNT 6.1 birch debug test xpcshell
Rev3 WINNT 6.1 birch debug test jsreftest n
Reporter | ||
Comment 8•13 years ago
|
||
Comment on attachment 609390 [details] [diff] [review]
remove unused branches
I got OK through emails from owners.
Attachment #609390 -
Flags: review?(coop)
Updated•13 years ago
|
Attachment #609390 -
Flags: review?(coop) → review+
Reporter | ||
Comment 9•13 years ago
|
||
Comment on attachment 609390 [details] [diff] [review]
remove unused branches
559f2545345b landed on "default"
Attachment #609390 -
Flags: checked-in+
Reporter | ||
Comment 10•13 years ago
|
||
This went live around 11:55AM PDT.
Reporter | ||
Updated•13 years ago
|
Priority: P1 → P3
Reporter | ||
Comment 11•13 years ago
|
||
Attachment #608480 -
Attachment is obsolete: true
Reporter | ||
Comment 12•13 years ago
|
||
I have my hands full.
I left attachment 615361 [details] [diff] [review] in case anyone wants to pick this up later on (even myself).
Assignee: armenzg → nobody
Reporter | ||
Comment 13•13 years ago
|
||
I am just refreshing the patch.
I haven't touched this for a while.
I don't have time to work on it yet.
Assignee | ||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
Comment 14•9 years ago
|
||
Probably not worth spending time on now that we're moving so much to Taskcluster.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Assignee | ||
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•