Closed Bug 737632 Opened 13 years ago Closed 9 years ago

Make sure that we only add as many builders as strictly necessary

Categories

(Release Engineering :: General, defect, P3)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: armenzg, Unassigned)

Details

Attachments

(4 files, 1 obsolete file)

I have seen few cases on mozilla-tests/config.py and mozilla/project_branches.py I will hopefully make it make more sense. This is necessary as I have few more suites to add and I am hitting the 1024 limit.
This is my first pass. I will try to get in touch with project owners and update their requirements as some branches like jaegermonkey are abandoned.
Attachment #608480 - Flags: review?(aki)
Attached patch diff off removed/added builders (deleted) — Splinter Review
I'm not entirely sure what you're trying to do here, so I'm going to wait til you're back to verify. It does look like you want to explicitly list what's in each project branch, which I approve of. It's hard to figure out what our current programmatic config is doing. In the meantime, I've run dump_masters to see what the net effect here will be. First, run dump_masters to get clean output: ~/src/clean/braindump/buildbot-related/dump_masters.sh 2>&1 >../clean.dump Then hg import and get patched output: hg import --no-commit ~/Desktop/less_builders.v4.diff ~/src/clean/braindump/buildbot-related/dump_masters.sh 2>&1 >../armen.dump Try to only get the information of changed builders: egrep '^[><] [a-zA-Z]' factory.diff >x Separate added and removed factory entries: grep '^>' x | sed -e 's/^> \(.*\)$/\1/'| sort | uniq >added grep '^<' x | sed -e 's/^< \(.*\)$/\1/'| sort | uniq >removed Get a summary of added/removed builders: diff -U0 removed added > summary Looks like we're removed 890 builders, which is great. Does this list look correct?
Attachment #608536 - Flags: feedback?(armenzg)
Hm, I got factory diff via diff ../{clean,armen}.dump | grep -i factory > ../factory.diff which I'm not sure is accurate, but then I doublechecked: diff clean.dump armen.dump | egrep '^[><] [a-zA-Z]' > X diff x X They're the same. I think the above file is still accurate.
see also bug 737661 where we have jetpack testers for platforms we don't build
Comment on attachment 608536 [details] [diff] [review] diff off removed/added builders Thanks for taking the time. I think my eyes were getting tired and just focusing on few branches. I will have an updated patch in few hours. BTW I use builder_list.py from braindump.py and comment out few lines to only output the build names.
Attachment #608536 - Flags: feedback?(armenzg) → feedback-
Attachment #608480 - Flags: review?(aki)
Attached patch remove unused branches (deleted) — Splinter Review
I will reach project owners for "graphics" and "jaegermonkey". I would like to remove "Pine" from the available lists and add it when extremely necessary.
I see "birch" (unused branch) as 'birch': {}, but I see all of these builders: Android birch build Android Debug birch build Android XUL birch build Linux birch build Linux birch leak test build Linux x86-64 birch build Linux x86-64 birch leak test build Linux QT birch build OS X 10.5.2 birch leak test build OS X 10.6.2 birch build OS X 10.6.2 birch leak test build WINNT 5.2 birch build WINNT 5.2 birch leak test build WINNT 6.1 x86-64 birch build These are just from the Windows testers: Rev3 WINNT 5.1 birch talos nochrome.2 Rev3 WINNT 5.1 birch talos chrome.2 Rev3 WINNT 5.1 birch talos dromaeo Rev3 WINNT 5.1 birch talos svg Rev3 WINNT 5.1 birch talos tpr_responsiveness Rev3 WINNT 5.1 birch talos dirty Rev3 WINNT 5.1 birch opt test mochitests-1/5 Rev3 WINNT 5.1 birch opt test mochitests-2/5 Rev3 WINNT 5.1 birch opt test mochitests-3/5 Rev3 WINNT 5.1 birch opt test mochitests-4/5 Rev3 WINNT 5.1 birch opt test mochitests-5/5 Rev3 WINNT 5.1 birch opt test mochitest-other Rev3 WINNT 5.1 birch opt test reftest Rev3 WINNT 5.1 birch opt test crashtest Rev3 WINNT 5.1 birch opt test xpcshell Rev3 WINNT 5.1 birch opt test jsreftest Rev3 WINNT 5.1 birch debug test mochitests-1/5 Rev3 WINNT 5.1 birch debug test mochitests-2/5 Rev3 WINNT 5.1 birch debug test mochitests-3/5 Rev3 WINNT 5.1 birch debug test mochitests-4/5 Rev3 WINNT 5.1 birch debug test mochitests-5/5 Rev3 WINNT 5.1 birch debug test mochitest-other Rev3 WINNT 5.1 birch debug test reftest Rev3 WINNT 5.1 birch debug test crashtest Rev3 WINNT 5.1 birch debug test xpcshell Rev3 WINNT 5.1 birch debug test jsreftest Rev3 WINNT 6.1 birch talos nochrome.2 Rev3 WINNT 6.1 birch talos chrome.2 Rev3 WINNT 6.1 birch talos dromaeo Rev3 WINNT 6.1 birch talos svg Rev3 WINNT 6.1 birch talos tpr_responsiveness Rev3 WINNT 6.1 birch talos dirty Rev3 WINNT 6.1 birch opt test mochitests-1/5 Rev3 WINNT 6.1 birch opt test mochitests-2/5 Rev3 WINNT 6.1 birch opt test mochitests-3/5 Rev3 WINNT 6.1 birch opt test mochitests-4/5 Rev3 WINNT 6.1 birch opt test mochitests-5/5 Rev3 WINNT 6.1 birch opt test mochitest-other Rev3 WINNT 6.1 birch opt test reftest Rev3 WINNT 6.1 birch opt test crashtest Rev3 WINNT 6.1 birch opt test xpcshell Rev3 WINNT 6.1 birch opt test jsreftest Rev3 WINNT 6.1 birch opt test reftest-no-accel Rev3 WINNT 6.1 birch debug test mochitests-1/5 Rev3 WINNT 6.1 birch debug test mochitests-2/5 Rev3 WINNT 6.1 birch debug test mochitests-3/5 Rev3 WINNT 6.1 birch debug test mochitests-4/5 Rev3 WINNT 6.1 birch debug test mochitests-5/5 Rev3 WINNT 6.1 birch debug test mochitest-other Rev3 WINNT 6.1 birch debug test reftest Rev3 WINNT 6.1 birch debug test crashtest Rev3 WINNT 6.1 birch debug test xpcshell Rev3 WINNT 6.1 birch debug test jsreftest n
Comment on attachment 609390 [details] [diff] [review] remove unused branches I got OK through emails from owners.
Attachment #609390 - Flags: review?(coop)
Attachment #609390 - Flags: review?(coop) → review+
Comment on attachment 609390 [details] [diff] [review] remove unused branches 559f2545345b landed on "default"
Attachment #609390 - Flags: checked-in+
This went live around 11:55AM PDT.
Priority: P1 → P3
I have my hands full. I left attachment 615361 [details] [diff] [review] in case anyone wants to pick this up later on (even myself).
Assignee: armenzg → nobody
I am just refreshing the patch. I haven't touched this for a while. I don't have time to work on it yet.
Product: mozilla.org → Release Engineering
Probably not worth spending time on now that we're moving so much to Taskcluster.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: