Closed
Bug 742195
Opened 13 years ago
Closed 12 years ago
Implement the extended attributes for null and undefined handling on string arguments in Paris bindings
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: bzbarsky, Assigned: peterv)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
We'll need it sometime.
Reporter | ||
Updated•13 years ago
|
Summary: Implement the extended attributes for null and undefined handling on strings → Implement the extended attributes for null and undefined handling on strings in Paris bindings
Assignee | ||
Comment 1•12 years ago
|
||
Assignee: nobody → peterv
Status: NEW → ASSIGNED
Assignee | ||
Updated•12 years ago
|
Attachment #654431 -
Flags: review?(bzbarsky)
Reporter | ||
Comment 2•12 years ago
|
||
Comment on attachment 654431 [details] [diff] [review]
v1
The mapping from the python enum to the C++ enum is a bit weird because we depend on treatAs having the same ordering as the python enum.
What if we used just a dict mapping the WebIDL string values to our desired string values, and then just stored the WebIDL string value in the IDLArgument? That would at least nix the ordering dependency. If we wanted to really be cool, we could change our C++ string values to match the WebIDL ones (e.g. replace eStringify with eDefault or something).
In the WebIDL parser, I don't think we should raise an error on TreatUndefinedAs=Missing. That's not a problem for the parser per se, and the codegen will already raise an error on it.
In the codegen, even if type.nullable() we need to examine treatUndefinedAs, no? In particular, if the argument is "[TreatUndefinedAs=EmptyString] DOMString?" then passing undefined should produce an empty string.
r=me with those last two bits fixed and maybe some parser tests added. A followup bug is fine for the string/enum stuff.
Attachment #654431 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #654431 -
Attachment is obsolete: true
Attachment #654854 -
Flags: review+
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #654854 -
Attachment is obsolete: true
Attachment #654874 -
Flags: review+
Reporter | ||
Comment 5•12 years ago
|
||
Flags: in-testsuite?
Target Milestone: --- → mozilla17
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•12 years ago
|
Summary: Implement the extended attributes for null and undefined handling on strings in Paris bindings → Implement the extended attributes for null and undefined handling on string arguments in Paris bindings
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•