Closed
Bug 743304
Opened 13 years ago
Closed 12 years ago
After SSH failure, Android XUL mozilla-central nightly builder spams a bunch of "SyntaxError: invalid syntax" when running retry.py / balrog-client.py
Categories
(Release Engineering :: General, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dholbert, Assigned: rail)
References
Details
Attachments
(3 files, 1 obsolete file)
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
catlee
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
catlee
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
Android XUL mozilla-central nightly on 2012-04-06 03:12:22 PDT for push da0d07b5ca1e
https://tbpl.mozilla.org/php/getParsedLog.php?id=10692174&tree=Firefox
That^ nightly build seems to have hit an SSH issue ("ssh: connect to host aus2-staging.mozilla.org port 22: Connection refused"), but it had much spammier / more cryptic issues afterwards, which I suspect might be a bug in our scripts that is only exposed on exceptions like this.
The chunk after that SSH failure has 5 repeated failures like this:
{{{
retry: Calling <function run_with_timeout at 0xb7cf510c> with args: (['python', '/builds/slave/m-cen-andrd-xul-ntly/tools/scripts/updates/balrog-client.py', '--build-properties', 'buildprops_balrog.json', '--api-root', 'https://aus4-admin-dev.allizom.org', '--verbose', '--credentials-file', 'BuildSlaves.py'], 1260, None, None, False, True), kwargs: {}, attempt #1
Executing: ['python', '/builds/slave/m-cen-andrd-xul-ntly/tools/scripts/updates/balrog-client.py', '--build-properties', 'buildprops_balrog.json', '--api-root', 'https://aus4-admin-dev.allizom.org', '--verbose', '--credentials-file', 'BuildSlaves.py']
Traceback (most recent call last):
File "/builds/slave/m-cen-andrd-xul-ntly/tools/scripts/updates/balrog-client.py", line 11, in <module>
from balrog.client.cli import NightlyRunner
File "/builds/slave/m-cen-andrd-xul-ntly/tools/lib/python/balrog/client/cli.py", line 7, in <module>
from balrog.client.api import API
File "/builds/slave/m-cen-andrd-xul-ntly/tools/lib/python/balrog/client/api.py", line 4, in <module>
import requests
File "/builds/slave/m-cen-andrd-xul-ntly/tools/lib/python/vendor/requests-0.10.8/requests/__init__.py", line 25, in <module>
from . import utils
File "/builds/slave/m-cen-andrd-xul-ntly/tools/lib/python/vendor/requests-0.10.8/requests/utils.py", line 232
return b"".join(L)
^
SyntaxError: invalid syntax
retry: Failed, sleeping 1 seconds before retrying
}}}
...followed by...
{{{
retry: Giving up on <function run_with_timeout at 0xb7cf510c>
Unable to successfully run ['python', '/builds/slave/m-cen-andrd-xul-ntly/tools/scripts/updates/balrog-client.py', '--build-properties', 'buildprops_balrog.json', '--api-root', 'https://aus4-admin-dev.allizom.org', '--verbose', '--credentials-file', 'BuildSlaves.py'] after 5 attempts
program finished with exit code 1
}}}
The SSH failure looks intermittent/connectivity-related (and is probably the proximate cause of bustage), but this syntax error looks like a real bug that we should fix.
Reporter | ||
Comment 1•13 years ago
|
||
Here's the relevant chunk of this log, from the failed SSH command up to the balrog-client.py syntax error issues (at the bottom).
Comment 2•13 years ago
|
||
Rail, can you take a look? It sounds like we might be using the wrong Python here? Or we have a buggy python-requests library?
Component: Release Engineering → Release Engineering: Automation (General)
QA Contact: release → catlee
Comment 3•13 years ago
|
||
looks like it's being run with python2.5 which doesn't support b"".
Assignee: nobody → rail
Assignee | ||
Comment 4•13 years ago
|
||
This should fix the problem
Attachment #615728 -
Flags: review?(catlee)
Assignee | ||
Comment 5•13 years ago
|
||
Comment on attachment 615728 [details] [diff] [review]
set PYTHON26 env for android{,-xul}
Seeing similar errors on Windows too.
Attachment #615728 -
Flags: review?(catlee)
Assignee | ||
Comment 6•13 years ago
|
||
Waiting for 2.7 on win32...
Attachment #615728 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Priority: -- → P3
Assignee | ||
Comment 7•13 years ago
|
||
Comment on attachment 616584 [details] [diff] [review]
set PYTHON26 env for android{,-xul}, win32
Once I'm done with bug 616584, I can deploy this.
Attachment #616584 -
Flags: review?(catlee)
Updated•13 years ago
|
Attachment #616584 -
Flags: review?(catlee) → review+
Assignee | ||
Comment 8•13 years ago
|
||
Comment on attachment 616584 [details] [diff] [review]
set PYTHON26 env for android{,-xul}, win32
http://hg.mozilla.org/build/buildbot-configs/rev/5e7816c35792
Attachment #616584 -
Flags: checked-in+
Assignee | ||
Comment 9•13 years ago
|
||
Worked fine for win32 nightlies. Android balrog submissions use proper python version and don't generate the reported error. However, it still can't submit updates. The corresponding issue is tracked in bug 746937,
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•13 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 10•13 years ago
|
||
Comment on attachment 616584 [details] [diff] [review]
set PYTHON26 env for android{,-xul}, win32
http://hg.mozilla.org/build/buildbot-configs/rev/b89597d25dfd
It causes win32 signing falures:
'bash' '-c' 'd:/mozilla-build/python27/python.exe e:/builds/moz2_slave/rel-m-beta-w32-bld/tools/release/signing/signtool.py --cachedir /e/builds/moz2_slave/rel-m-beta-w32-bld/signing_cache -t /e/builds/moz2_slave/rel-m-beta-w32-bld/token -n /e/builds/moz2_slave/rel-m-beta-w32-bld/nonce -c e:/builds/moz2_slave/rel-m-beta-w32-bld/tools/release/signing/host.cert -H signing1.build.scl1.mozilla.com:9120 -H signing2.build.scl1.mozilla.com:9120 -f gpg -f mar ""build/obj-firefox/dist/update/win32/en-US/firefox-13.0b2-13.0b3.partial.mar""'
....
IOError: [Errno 2] No such file or directory: '\\build/obj-firefox/dist/update/win32/en-US/firefox-13.0b2-13.0b3.partial.mar\\'
Attachment #616584 -
Flags: checked-in+ → checked-in-
Assignee | ||
Comment 11•12 years ago
|
||
The patch removes extra quotes. Passed staging.
Attachment #624606 -
Flags: review?(catlee)
Updated•12 years ago
|
Attachment #624606 -
Flags: review?(catlee) → review+
Assignee | ||
Comment 12•12 years ago
|
||
Comment on attachment 624606 [details] [diff] [review]
Remove extra quotes
http://hg.mozilla.org/build/buildbotcustom/rev/b5ca2e87801b
Attachment #624606 -
Flags: checked-in+
Assignee | ||
Comment 13•12 years ago
|
||
Comment on attachment 616584 [details] [diff] [review]
set PYTHON26 env for android{,-xul}, win32
http://hg.mozilla.org/build/buildbot-configs/rev/d518706b4646
Attachment #616584 -
Flags: checked-in- → checked-in+
Comment 14•12 years ago
|
||
in production 2012-05-17 0750 PDT
Assignee | ||
Updated•12 years ago
|
Status: REOPENED → RESOLVED
Closed: 13 years ago → 12 years ago
Resolution: --- → FIXED
Comment 15•12 years ago
|
||
Comment on attachment 616584 [details] [diff] [review]
set PYTHON26 env for android{,-xul}, win32
The win32 portion of this patch was backed out in bug 758064 due to win32 release l10n repack bustage.
Updated•12 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 16•12 years ago
|
||
maybe msys is doing it? http://www.mingw.org/wiki/Posix_path_conversion
Assignee | ||
Comment 17•12 years ago
|
||
Closing this one and reopening bug 758064, which has more details related to the win32 part of the bug.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•