See https://bugzilla.mozilla.org/show_bug.cgi?id=745975#c2 . Setting properties should be a generic method in BuildbotMixin. The l10n script could then have a wrapper method that takes locale, message, and status, and can both self.add_summary() and self.set_buildbot_property(). Not sure if this method lives in the script or in LocalesMixin or what. We should also perhaps add a string at the beginning and end of each compare-locale run: "compare locales output per locale could be sandwiched between easily identified headers like *** BEGIN compare_locales ab-CD .... *** END compare_locales ab-CD "

I *think* this would work but a run through ScriptFactory with the properties set properly would be best. I'd also like to see a failing l10n repack get marked as such... pretty sure that's easily doable on m-c.

Still had old logic lying around that created a 'locales' property as a list of comma-delineated locales. Removed.

Ok. This patch is tested in staging (with some staging-specific changes for testing purposes). I correctly created the locales property and wrote the file: 14:42:59 INFO - Setting buildbot property locales to {"ja-JP-mac": "Success", "ko": "Success", "it": "Success", "hu": "Success", "lt": "Success", "id": "Success", "nb-NO": "Success", "ja": "Success", "he": "Failed"} 14:42:59 INFO - mkdir: /builds/slave/m-cen-andrd-l10n-3/properties 14:42:59 INFO - Writing buildbot properties ['locales'] to /builds/slave/m-cen-andrd-l10n-3/properties/locales 14:42:59 INFO - Writing to file /builds/slave/m-cen-andrd-l10n-3/properties/locales 14:42:59 INFO - Contents: 14:42:59 INFO - locales:{"ja-JP-mac": "Success", "ko": "Success", "it": "Success", "hu": "Success", "lt": "Success", "id": "Success", "nb-NO": "Success", "ja": "Success", "he": "Failed"} The SetProperty step in ScriptFactory correctly read the string: locales:{"ja-JP-mac": "Success", "ko": "Success", "it": "Success", "hu": "Success", "lt": "Success", "id": "Success", "nb-NO": "Success", "ja": "Success", "he": "Failed"} However, SetProperty then set this property: locales: '{"ja-JP-mac"' I think we have to replace the bash call with something else, or do something ugly in a single string without quotes. Or escape all the quotes (YUCK) I think we need to morph bug 724221 to not use bash before we can do this.

(In reply to Aki Sasaki [:aki] from comment #3) > However, SetProperty then set this property: > > locales: '{"ja-JP-mac"' > > I think we have to replace the bash call with something else, or do > something ugly in a single string without quotes. Or escape all the quotes > (YUCK) > I think we need to morph bug 724221 to not use bash before we can do this. Actually, I think the splitting on colons is at fault here: http://hg.mozilla.org/build/buildbotcustom/file/97126886e152/process/factory.py#l8489

Only split on the leftmost colon. Skip the line if there's no colon.

This works when run with the above buildbotcustom patch. The following two properties were set for a staging Android mozilla-central l10n nightly 3/5 run: he_failure: "he failed in make installers-he! Can't create a snippet for he without an upload url." locales: '{"ja-JP-mac": "Success", "ko": "Success", "it": "Success", "hu": "Success", "lt": "Success", "id": "Success", "nb-NO": "Success", "ja": "Success", "he": "Failed"}'

Comment on attachment 617681 [details] [diff] [review] fix ScriptFactory's extractProperties http://hg.mozilla.org/build/buildbotcustom/rev/28ed61ce33a4

Comment on attachment 617684 [details] [diff] [review] mozharness buildbot property support Review of attachment 617684 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for the delay, buildduty :/ ::: mozharness/mozilla/buildbot.py @@ +77,5 @@ > + if not prop_list: > + prop_list = self.buildbot_properties.keys() > + self.info("Writing buildbot properties to %s" % file_name) > + else: > + if not isinstance(prop_list, list): could be if not isinstance(prop_list, (list, tuple)): or even if not callable(getattr(prop_list, '__iter__', None)): :)

Comment on attachment 617684 [details] [diff] [review] mozharness buildbot property support http://hg.mozilla.org/build/mozharness/rev/6cf10e691609 (In reply to Rail Aliiev [:rail] from comment #8) > Sorry for the delay, buildduty :/ No worries. > ::: mozharness/mozilla/buildbot.py > @@ +77,5 @@ > > + if not prop_list: > > + prop_list = self.buildbot_properties.keys() > > + self.info("Writing buildbot properties to %s" % file_name) > > + else: > > + if not isinstance(prop_list, list): > > could be > if not isinstance(prop_list, (list, tuple)): Done. We should now have per-locale status properties in Android single locale repacks. Once we move desktop repacks to mozharness, we'll have per-locale status properties there as well, though Windows may be delayed until bug 724221 is resolved.