Once we've fixed the dependent issues, we can drop the old Thunderbird MoMo based try server and swap the try-comm-central builds from publishing to thunderbird-test to thunderbird.

Comment on attachment 619905 [details] [diff] [review] search/replace test keys in BRANCHES['try-comm-central'] Sorry, but I don't really like this obfuscated way of changing configs. It may hurt us in a unpredicted way. I'd prefer to have these changes per branch explicitly (for BRANCHES['try-comm-central']).

move enabled_products to local branch scope

Comment on attachment 620014 [details] [diff] [review] upload try-comm-central to thunderbird/ Review of attachment 620014 [details] [diff] [review]: ----------------------------------------------------------------- You should also adjust try-comm-central section of thunderbird_production_config.py: http://hg.mozilla.org/build/buildbot-configs/file/78dab225839b/mozilla/thunderbird_production_config.py#l77 ::: mozilla/thunderbird_config.py @@ +1040,5 @@ > BRANCHES['try-comm-central']['platforms'][platform]['stage_product'] = 'thunderbird-test' > > +# MAKE THUNDERBIRD TRY LIVE > +BRANCHES['try-comm-central']['product_name'] = 'thunderbird' > +BRANCHES['try-comm-central']['download_base_url'] = 'http://dev-stage01.build.sjc1.mozilla.com/pub/mozilla.org/thunderbird' The line above doesn't look proper to me. I think that you should adjust this variable here: http://hg.mozilla.org/build/buildbot-configs/file/78dab225839b/mozilla/thunderbird_production_config.py#l80

This is a patch for the unit test part that incorporates the fix for bug 750634 - try server not having any unit test builders. This patch is probably safer than the one proposed there, and should fix the unit test builds on try server, and have everything running with "thunderbird" rather than "thunderbird-test". I'm not convinced the stage_product change is actually required, because PLATFORMS isn't used (the use is commented out) whereas PLATFORM_UNITTEST_VARS is used. Untested as I don't have anything to test it on, but given the similarity to the bug 750634 that we've already tested and the other patch on this bug then I think it shouldn't be too far off.

Comment on attachment 620232 [details] [diff] [review] Unit test server fix Review of attachment 620232 [details] [diff] [review]: ----------------------------------------------------------------- This patch gets us our try-comm-central xpcshell/mozmill builders - looks good.

This fixes the download_base_url issue in the main patch, and also fixes the production config. It also merges in the unit test config patch.

Checked in: http://hg.mozilla.org/build/buildbot-configs/rev/34eb5beb7269

Excluding issues on the builders that I'm fixing up elsewhere, this is now complete.