Closed
Bug 754142
Opened 13 years ago
Closed 12 years ago
ASSERTION: Why don't we have a Window here?
Categories
(Core :: Storage: IndexedDB, defect)
Tracking
()
People
(Reporter: gwagner, Assigned: khuey)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
###!!! ASSERTION: Why don't we have a Window here?: 'window', file /Users/idefix2/code/gaia/src/dom/indexedDB/IndexedDatabaseManager.cpp, line 870
WARNING: NS_ENSURE_TRUE(sop) failed: file /Users/idefix2/code/gaia/src/dom/indexedDB/CheckQuotaHelper.cpp, line 77
WARNING: SQLite returned error code 1 , Storage will convert it to NS_ERROR_FAILURE: file /Users/idefix2/code/gaia/src/storage/src/mozStoragePrivateHelpers.cpp, line 113
WARNING: Failed to rollback transaction!: file /Users/idefix2/code/gaia/src/dom/indexedDB/IDBTransaction.cpp, line 771
Maybe khuey can take this?
Assignee | ||
Comment 2•13 years ago
|
||
Not without a test case or any useful STR.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → INCOMPLETE
Reporter | ||
Comment 3•13 years ago
|
||
Use the emulator build of B2G: https://wiki.mozilla.org/Gaia/Hacking and load a bunch of contacts via "UI tests"->"Insert fake contacts"
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Assignee | ||
Comment 4•13 years ago
|
||
Some context would have been useful in the bug report.
Assignee: nobody → khuey
Status: REOPENED → ASSIGNED
Attachment #623738 -
Flags: review?(bent.mozilla)
Comment on attachment 623738 [details] [diff] [review]
Patch
Review of attachment 623738 [details] [diff] [review]:
-----------------------------------------------------------------
We talked about this, and we think there is a better way.
Attachment #623738 -
Flags: review?(bent.mozilla)
Reporter | ||
Comment 6•13 years ago
|
||
Now I need a way to set dependencies to the gaia repository...
This blocks the favorite-contact feature for gaia.
Assignee | ||
Comment 7•13 years ago
|
||
There's a reason we track everything in Bugzilla ;-)
Assignee | ||
Comment 8•13 years ago
|
||
Attachment #623738 -
Attachment is obsolete: true
Attachment #623817 -
Flags: review?(bent.mozilla)
Comment on attachment 623817 [details] [diff] [review]
Patch
Review of attachment 623817 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/indexedDB/IndexedDatabaseManager.cpp
@@ +716,3 @@
> NS_ENSURE_TRUE(ss, NS_ERROR_FAILURE);
>
> + if (mPrivilege == Content) {
Let's do != Chrome here, and below.
Attachment #623817 -
Flags: review?(bent.mozilla) → review+
Comment 10•13 years ago
|
||
My build is broken with this error. I am using GCC 4.7.
../../../dist/include/mozilla/dom/indexedDB/IndexedDatabaseManager.h:72:6: error: use of enum ‘FactoryPrivilege’ without previous declaration
../../../dist/include/mozilla/dom/indexedDB/IndexedDatabaseManager.h:158:38: error: ‘FactoryPrivilege’ has not been declared
Assignee | ||
Comment 11•13 years ago
|
||
Tried to land this, but GCC doesn't like forward declared enums.
Reporter | ||
Comment 12•13 years ago
|
||
Kyle, any chance you can fix this?
Assignee | ||
Comment 13•13 years ago
|
||
It's on the list. There's another problem here we still need to solve though. deleteDatabase uses sqlite3_quota_remove to delete files, and if we don't install the quota handler that doesn't work.
We need to fix this.
Blocks: 726378
I think i fixed the places where sqlite3_quota_remove wasn't removing files (in the android test patch). And use a bool (mIsChrome? mIsPrivileged?) instead of the enum.
Not blocking unprefixing since this doesn't affect web developers. But still important to fix of course.
No longer blocks: 726378
blocking-basecamp: --- → ?
blocking-basecamp: ? → +
Reporter | ||
Comment 17•12 years ago
|
||
Can we fix this now with a bool as ben suggested?
Reporter | ||
Comment 18•12 years ago
|
||
Ping! We really need this fixed.
Assignee | ||
Comment 19•12 years ago
|
||
Comment 20•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago → 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•