So if this lands, should I use something like db.mozCreateFile() in writable files patch ?

Yeah. And we should moz-prefix getAll. However I don't think we should fix this bug at least until our error handling has improved to match that of the spec.

About getAll : I use it

About get All : I use it in production, in a real world application (used by more than 1000 people), and it proved to be a really useful method. It's both really fast (compared to cursor iteration) and very handy. I would definitely advocate keeping it, whether it will be in the spec one day or not. Just my 2 cents... thanks.

Maxime: No-one is suggesting we remove it. I'm just saying we should prefix it until it's in spec.

Comment on attachment 637200 [details] [diff] [review] Patch Review of attachment 637200 [details] [diff] [review]: ----------------------------------------------------------------- You need to prefix getAll and getAllKeys at the same time too.

Comment on attachment 637200 [details] [diff] [review] Patch I don't think we should prefix those methods. There's only one reasonable thing they can do, so I don't think we're constraining the future spec in any meaningful way by doing this.

(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #8) I'm with sicking on this. It's unlikely, but something like switching the order of the two optional args could happen. Or something we can't predict. And we should set a good example.

I'm still not thrilled about this, but here's the patch.

Comment on attachment 637763 [details] [diff] [review] Patch Review of attachment 637763 [details] [diff] [review]: ----------------------------------------------------------------- r=me, but we should only check this in once all dependencies are fixed.

Unfortunately I had to backout bug 758357 due to it causing bug 770085, so I assume that Jonas' requirement that all dependencies be fixed before we ship this are now no longer upheld...

All pages of doc have been unprefixed long ago + info up-to-date on https://developer.mozilla.org/en-US/Firefox/Releases/16#API.2FDOM