Closed
Bug 755509
Opened 13 years ago
Closed 13 years ago
Add tests to ensure that deleteDatabase sets undefined success result
Categories
(Core :: Storage: IndexedDB, defect)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: khuey, Assigned: khuey)
References
Details
Attachments
(2 files)
(deleted),
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•13 years ago
|
||
This is just moving code around.
Assignee | ||
Comment 2•13 years ago
|
||
Attachment #624894 -
Flags: review?(jonas)
Attachment #624892 -
Flags: review?(jonas) → review+
Attachment #624894 -
Flags: review?(jonas) → review+
Assignee | ||
Comment 3•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1143cf39246f
https://hg.mozilla.org/mozilla-central/rev/38c9289bdf6d
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
OS: Windows 7 → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Summary: deleteDatabase should set undefined success result → Add tests to ensure that deleteDatabase sets undefined success result
Target Milestone: --- → mozilla15
Version: unspecified → Trunk
Comment 4•13 years ago
|
||
Comment on attachment 624894 [details] [diff] [review]
Part 2: Test explicitly for undefined.
>- is(event.target.result, null, "event should have no result");
>+ ok(event.target.result === undefined, "event should have no result");
ise(event.target.result, undefined, "event should have undefined result");
Assignee | ||
Comment 5•13 years ago
|
||
No, is does ==, not ===.
Comment 6•13 years ago
|
||
The 'ise' instead of 'is' was not a typo; 'ise' does use ===
Assignee | ||
Comment 7•13 years ago
|
||
Sounds like someone needs to update https://developer.mozilla.org/en/Mochitest#Test_functions then.
You need to log in
before you can comment on or make changes to this bug.
Description
•