Closed
Bug 755511
Opened 13 years ago
Closed 12 years ago
Revert all in-memory data when aborting versionchange transactions.
Categories
(Core :: Storage: IndexedDB, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: khuey, Assigned: khuey)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
No description provided.
By the way, this includes reverting the .indexNames property on deleted objectStores.
|
Assignee | |
Comment 2•12 years ago
|
||
This patch won't revert the indexNames property for deleted object stores, will it?
|
|
Assignee | |
Comment 4•12 years ago
|
||
Sure it will. Look at the test.
Comment on attachment 637100 [details] [diff] [review]
Patch
Review of attachment 637100 [details] [diff] [review]:
-----------------------------------------------------------------
r- due to the deleted object stores thing.
::: dom/indexedDB/test/error_events_abort_transactions_iframe.html
@@ +156,4 @@
> ok(db.objectStoreNames.contains("foo"), "Has correct objectStore");
> + ok(db.objectStoreNames.contains("bar"), "Has correct objectStore");
> +
> + db.close();
Why add this .close() call? Might be nicer to not have that to make sure that we revert even if the database isn't explicitly closed.
Attachment #637100 -
Flags: review?(bent.mozilla) → review-
|
|
Assignee | |
Comment 6•12 years ago
|
||
The db.close call is necessary to start the next versionchange transaction.
Attachment #637100 -
Attachment is obsolete: true
Attachment #637645 -
Flags: review?(jonas)
Attachment #637645 -
Flags: review?(jonas) → review+
|
|
Assignee | |
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
|
||
Updated•8 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•