Closed
Bug 75838
Opened 24 years ago
Closed 24 years ago
rewrite file picker to use outliner
Categories
(SeaMonkey :: UI Design, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.2
People
(Reporter: bugzilla, Assigned: bryner)
References
Details
(Keywords: perf)
Attachments
(2 files)
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review |
summary sez it all. sorry, bryner --i couldn't find an existing bug for this. i
want to file this so that issues like bug 70628 can be duped [or, dependent if
necessary] against it.
Reporter | ||
Updated•24 years ago
|
Assignee | ||
Comment 1•24 years ago
|
||
I checked in a work-in-progress version of this rewrite. To try it out:
cvs up -rOUTLINER_FILEPICKER_BRANCH themes/modern/global/filepicker.css
themes/classic/global/win/filepicker.css xpfe/components/filepicker/res/content
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.1
Assignee | ||
Comment 2•24 years ago
|
||
In addition to the above files, you will also need to get xpfe/components/jar.mn
from the branch.
Comment 5•24 years ago
|
||
Not critical for beta, so moving to 0.9.2. Brian says the work is done though,
so if reviews come in before Friday it would still be good to land this for beta.
Target Milestone: mozilla0.9.1 → mozilla0.9.2
Comment 6•24 years ago
|
||
I've looked at the stuff on the branch, it looks good. r=jag
Assignee | ||
Comment 7•24 years ago
|
||
Assignee | ||
Comment 8•24 years ago
|
||
Assignee | ||
Comment 9•24 years ago
|
||
Note that xpfe/components/filepicker/res/content/filepicker.css is also removed,
with this landing.
Comment 10•24 years ago
|
||
bryner: peter said you needed a hand landing this. how may i be of service? :)
Comment 11•24 years ago
|
||
outlinercell-inset-header on the outlinercols is unnecessary. Also, some of
the functions would be easier to read if they had more descriptive parameter
names.
sr=blake with all the stuff we discussed...
Comment 12•24 years ago
|
||
i hate to say this but i'm not convinced this is ready yet...
i've seen some strange visual bugs including the list being entirely one file
name while it loads, the scrollbar not scrolling dynamically in directories with
many files, and weird jumpyness as the list comes in...
i've also had it lock up on me and this is all just with very basic usage...
the keyboard control feels slugish and the buttons don't feel quite right.
anyway this feels harsh and some of it is prob the limitations of xul and
outliner... not sure...
Comment 13•24 years ago
|
||
i approve, course it's already checked in but what they hey ;-)
Assignee | ||
Comment 14•24 years ago
|
||
branch is checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 15•24 years ago
|
||
vrfy fixed with verif and debug bits from 5/23. new/separate issues to separate
bugs. :)
Status: RESOLVED → VERIFIED
Comment 16•23 years ago
|
||
*** Bug 103476 has been marked as a duplicate of this bug. ***
Updated•20 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•