Closed
Bug 758497
Opened 13 years ago
Closed 12 years ago
Figure out Cursor.advance arg size
Categories
(Core :: Storage: IndexedDB, defect)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: bent.mozilla, Assigned: khuey)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
The spec says Cursor.advance is supposed to be unsigned long, but then also says that we're supposed to throw on negative numbers. Our code has PRInt32, which means we can't accept PR_UINT32_MAX like we're probably supposed to. Need to figure out what to do here.
|
Assignee | |
Comment 1•12 years ago
|
||
This is now written with [EnforceRange], so I think we should punt on this until we have new bindings for IDB.
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 637182 [details] [diff] [review]
Patch
Review of attachment 637182 [details] [diff] [review]:
-----------------------------------------------------------------
r+ if you add a test.
Attachment #637182 -
Flags: review?(bent.mozilla) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in
before you can comment on or make changes to this bug.
Description
•