the mock configurations in bug 759975 assume that there will be a /builds/ccache directory that can be bind mounted into the mock environment. this module manages that directory, as well as setting the max ccache size.

Comment on attachment 629176 [details] [diff] [review] ccache modules Review of attachment 629176 [details] [diff] [review]: ----------------------------------------------------------------- ::: modules/dirs/manifests/builds/ccache.pp @@ +11,5 @@ > + } > + > + exec { > + "ccache-maxsize": > + require => [File["/builds/ccache"], Class["packages::ccache"]], Two concerns here. First, does this really need to run on every puppet invocation? From stracing it, it seems to store the cache size in the cache itself (in $digit/stats files, each getting 1/16th of the cache size). Second, this (and the packages include) does not belong in the dirs module. Better to add a new 'ccache' module to manage this. The new module should get docs on https://wiki.mozilla.org/ReleaseEngineering/PuppetAgain/Modules, too.

this adds a ccache::ccache_dir define so we can set up multiple ccache directories if we want. $ccache_dir/.puppet-maxsize is created with the contents of the $maxsize parameter, so that "ccache -M$maxsize" is only run when the maxsize changes. Running "ccache -C" also deletes this file and so would trigger re-running this exec; however we don't run "ccache -C" in any of the automation, so this shouldn't be a concern.

Comment on attachment 629792 [details] [diff] [review] ccache module Review of attachment 629792 [details] [diff] [review]: ----------------------------------------------------------------- lgtm

pushed

Can you write up documentation on how to use the class linked from https://wiki.mozilla.org/ReleaseEngineering/PuppetAgain Thanks!