Closed
Bug 761965
Opened 13 years ago
Closed 13 years ago
Fix up Balrog xml output
Categories
(Release Engineering :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: nthomas, Assigned: nthomas)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bhearsum
:
review+
|
Details | Diff | Splinter Review |
We currently have a wonky newline for around the detailsURL and don't write valid XML due to bare ampersands. This makes comparisons to AUS2 output hard, and Firefox barf on the XML respectively.
|
Assignee | |
Comment 1•13 years ago
|
||
I looked into using some of the XML libraries that Python has to see if we can avoid rolling too much custom-code around XML but didn't find anything well suited. If we don't mind losing the current pretty-print form and fixed ordering of attributes we could swap to xml.etree.ElementTree, otherwise most libraries seem to be based around parsing files and generally overkill.
Attachment #630484 -
Flags: review?(bhearsum)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 630484 [details] [diff] [review]
Fixes
Review of attachment 630484 [details] [diff] [review]:
-----------------------------------------------------------------
We're only doing a tiny amount of XML printing, this should be fine.
Attachment #630484 -
Flags: review?(bhearsum) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
|
|
||
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•