Closed
Bug 762206
Opened 13 years ago
Closed 12 years ago
Use nsScriptErrorEvent when firing error events on window objects
Categories
(Core :: Storage: IndexedDB, defect)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: bent.mozilla, Assigned: khuey)
References
Details
Attachments
(1 file)
(deleted),
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
We fire a plain Event at them now, but that doesn't unwrap properly when hitting window.onerror. The fix is to use nsScriptErrorEvent.
Assignee | ||
Comment 1•12 years ago
|
||
Comment on attachment 637147 [details] [diff] [review]
Patch
Review of attachment 637147 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with that fixed
::: dom/indexedDB/IDBObjectStore.cpp
@@ +1464,5 @@
> if (!IsWriteAllowed()) {
> return NS_ERROR_DOM_INDEXEDDB_READ_ONLY_ERR;
> }
>
> + nsRefPtr<IDBRequest> request = GenerateRequest(this, nsnull);
Why null here?
Attachment #637147 -
Flags: review?(bent.mozilla) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Because that function is only called in the parent process when doing IPC indexedDB, so there's no script information to get.
Bent explained why things work the way they do. Nothing to see here, move along. r+ stands.
Assignee | ||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in
before you can comment on or make changes to this bug.
Description
•