Closed
Bug 768684
Opened 12 years ago
Closed 12 years ago
Fix sequence<any> return type in WebIDL
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: peterv, Assigned: peterv)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
The codegen check for type any before checking for sequence, we need to invert that.
Attachment #636908 -
Flags: review?(bzbarsky)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 636908 [details] [diff] [review]
v1
Hmm. Does tag() on sequences forward on to the inner? That seems bogus to me (and in fact there's an XXX comment by Kyle about it). This also means that isAny() returns true for sequence<any>, which is broken. And I guess isObject() and isDate() have similar problems.
I would prefer we just fix isAny() to work correctly and use it here. For now we can just check |not self.isSequence()| in there in addition to the tag check (and similar for isDate() and isObject()), but we should really just fix the tag() on sequence behavior....
Attachment #636908 -
Flags: review?(bzbarsky) → review-
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #636908 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•12 years ago
|
Attachment #655679 -
Flags: review?(bzbarsky)
|
|
||
Comment 3•12 years ago
|
||
Comment on attachment 655679 [details] [diff] [review]
v2
r=me
Attachment #655679 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Target Milestone: --- → mozilla18
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
||
Updated•12 years ago
|
Blocks: ParisBindings
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•