GCLI Autocomplete goes wild when boolean params are used in a group: 1. Install the patch from bug 769560 2. Type the following: jsb http://code.jquery.com/jquery-1.7.2.min.js --jslintHappy 3. Press space and you get the completion for braceStyle. 4. Add --braceStyle and choose collapse from the popup and it overwrites braceStyle

Triage, filter on TEABAGS

a.k.a https://github.com/campd/gcli/pull/57

Joe said that if we add the following to OutputPanel.prototype.update = function OP_update(): if (this.displayedOutput.data.completed) { // Hide progress } else { // Show progress } Here is a complete(ish) progress implementation from elsewhere: OutputView.prototype.changed = function(ev) { var document = this.elems.rowout.ownerDocument; var duration = this.outputData.duration != null ? 'completed in ' + (this.outputData.duration / 1000) + ' sec ' : ''; duration = document.createTextNode(duration); this.elems.duration.appendChild(duration); if (this.outputData.completed) { this.elems.prompt.classList.add('gcli-row-complete'); } if (this.outputData.error) { this.elems.prompt.classList.add('gcli-row-error'); } this.outputData.toDom(this.elems.rowout); // We need to see the output of the latest command entered // Certain browsers have a bug such that scrollHeight is too small // when content does not fill the client area of the element var scrollHeight = Math.max(this.outputTerminal.element.scrollHeight, this.outputTerminal.element.clientHeight); this.outputTerminal.element.scrollTop = scrollHeight - this.outputTerminal.element.clientHeight; this.elems.throb.style.display = this.outputData.completed ? 'none' : 'block'; };

Ignore my previous comment, wrong bug.

rebase and update tests to suite in gcli

Comment on attachment 654968 [details] [diff] [review] v2 Review of attachment 654968 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/commandline/CmdJsb.jsm @@ +118,5 @@ > + if (xhr.status == 200 || xhr.status == 0) { > + let browserDoc = context.environment.chromeDocument; > + let browserWindow = browserDoc.defaultView; > + let browser = browserWindow.gBrowser; > + Trailing space

Backed out in: https://hg.mozilla.org/integration/fx-team/rev/f4596ef17eed

Re-land https://tbpl.mozilla.org/?tree=Fx-Team&rev=c80d0e010be3

https://hg.mozilla.org/mozilla-central/rev/c80d0e010be3 was the relanded changeset.