Jonathan Griffin (:jgriffin) Assignee
	Description • 12 years ago

In bug 772310, I changed Marionette to use prefHasUserValue before attempting to read the pref, in order to avoid a spurious assert on Firefox.

On B2G, this disables Marionette.  It turns out that prefHasUserValue is only true if that pref has a non-default value.  For B2G, the default value is true, and thus prefHasUserValue returns false.

	Jonathan Griffin (:jgriffin) Assignee
	Comment 1 • 12 years ago

This patch uses a try/catch block when reading the marionette.defaultPrefs.enabled pref, so it will work whether or not it has a default value.

It also reorganizes the logging code in the same file a bit to make troubleshooting marionette-isn't-loading problems a bit easier.

	Malini Das [:mdas] - Away, not checking bugmail
	Comment 2 • 12 years ago

Comment on attachment 642836 [details] [diff] [review]
patch v0.3

Review of attachment 642836 [details] [diff] [review]:
-----------------------------------------------------------------

good catch, thanks!

	Jonathan Griffin (:jgriffin) Assignee
	Comment 3 • 12 years ago

http://hg.mozilla.org/integration/mozilla-inbound/rev/2e3a7f87629c

	Ed Morley [:emorley]
	Comment 4 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/2e3a7f87629c