Basically if the 'b2g.privileged.domains' pref is not set in prefs.js I was noticing a problem loading mochitests. The reason is generally split returns one element and we are attempting to addPermissions for what is an empty string, without appropriate protections inside addPermsissions. let domains = ""; try { domains = Services.prefs.getCharPref('b2g.privileged.domains'); } catch(e) {} addPermissions(domains.split(","));

Comment on attachment 643318 [details] [diff] [review] b2g patch The alternative is to add some dummy domains to the pref in the mochitest test profile.

Comment on attachment 643318 [details] [diff] [review] b2g patch Review of attachment 643318 [details] [diff] [review]: ----------------------------------------------------------------- ::: b2g/chrome/content/shell.js @@ +62,3 @@ > urls.forEach(function(url) { > url = url.trim(); > + if (url.length > 0 ) { Could just be `if (url.length)` or even `if (url)`. Looks good otherwise.