dclarke@mozilla.com [:onecyrenus] Assignee
	Description • 12 years ago

Current method is to listFiles in /data/data to determine if we have root on the device. 

I think we can do this using adb shell "id" command to get the guid / uid of the current user ?

	Jonathan Griffin (:jgriffin)
	Comment 1 • 12 years ago

The problem with the existing method is that /data/data is empty on B2G, so devicemanager never recognizes that we are running as root.

	Joel Maher ( :jmaher ) (UTC -8)
	Comment 2 • 12 years ago

Comment on attachment 643981 [details] [diff] [review]
A patch that checks the guid / uid of the current user to determine if they are root on the device

Review of attachment 643981 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/mobile/devicemanagerADB.py
@@ +808,5 @@
> +    response = p.stdout.readline()
> +    response = response.rstrip()
> +    response = response.split(' ')
> +    if (response[0].find('uid=0') < 0 or response[1].find('gid=0') < 0):
> +      print "NOT running as root ", response[0].find('uid=0')

do we want to raise a DMError here?

	Jonathan Griffin (:jgriffin)
	Comment 3 • 12 years ago

posted to try, just in case

	Jonathan Griffin (:jgriffin)
	Comment 4 • 12 years ago

try ate my last submission, tried again:  https://tbpl.mozilla.org/?tree=Try&rev=190945a1d0e7

	Mozilla RelEng Bot
	Comment 5 • 12 years ago

Try run for 190945a1d0e7 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=190945a1d0e7
Results (out of 29 total builds):
    exception: 8
    success: 16
    warnings: 4
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jgriffin@mozilla.com-190945a1d0e7

	Jonathan Griffin (:jgriffin)
	Comment 6 • 12 years ago

http://hg.mozilla.org/mozilla-central/rev/f91c1b55b396

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/2bfd0b750bb1