I've created a new dmg for 10.8 which I've copied to /data and will attach a patch for the changes I've tested.

I also added minimal changes to the builder.pp class to support this, there are more changes forthcoming to this class. I'm trying to create smaller patches so they are easier for reviewers to parse.

I should have mentioned that I built the dmg from the source here git://github.com/jhford/screenresolution.git

Comment on attachment 644990 [details] [diff] [review] patch My only complaint here is that there's no docs or shell-script on how the screenresolution DMG was made, so if I needed to re-create it for a new version, or if Apple decides to switch CPUs again, I'm at a loss. I'd like to get this user stuff settled once and for all - it's causing a lot of churn both in your patches and mine. So I'll open a new bug, but for now anything goes to get the other patches working :) So, r+ conditioned on the addition of a shell script that builds the DMG. It looks like that may be as simple as downloading a tag from github (I don't see 1.6 there?) and running 'make dmg', but such a script both documents those simple steps (I had no idea where the source was until I just asked in IRC) and provides a basis for future, possibly more complicated approaches (e.g., at some point we may want to install in /tools and link, like the other custom packages).

Documented here https://wiki.mozilla.org/ReleaseEngineering/PuppetAgain/Modules/packages#packages::mozilla::screenresolution

Now that the other user stuff is working, I'm seeing err: /Stage[main]/Users::Builder/Exec[verify-resolution]/returns: change from notrun to 0 failed: /usr/local/bin/screenresolution set 1280x1024x32 returned 1 instead of one of [0] at /etc/puppet/environments/dmitchell/env/modules/users/manifests/builder.pp:119 bash-3.2# /usr/local/bin/screenresolution set 1280x1024x32 2012-07-26 10:15:30.770 screenresolution[6260:707] starting screenresolution argv=/usr/local/bin/screenresolution set 1280x1024x32 2012-07-26 10:15:30.775 screenresolution[6260:707] Error: the mode '1280x1024x32' couldn't be parsed bash-3.2# /usr/local/bin/screenresolution get 2012-07-26 10:15:39.656 screenresolution[6261:707] starting screenresolution argv=/usr/local/bin/screenresolution get 2012-07-26 10:15:39.661 screenresolution[6261:707] Display 0: 1600x1200x32@60 bash-3.2# /usr/local/bin/screenresolution set 1280x1024x32@60 2012-07-26 10:15:47.001 screenresolution[6262:707] starting screenresolution argv=/usr/local/bin/screenresolution set 1280x1024x32@60 2012-07-26 10:15:47.006 screenresolution[6262:707] set mode on display 0 to 1280x1024x32@60 So maybe the required string is different?

Yes, I saw that yesterday too. The default resolution is 1600x1200x32@60. Not sure what it should be for the tests to run correctly, I'll ask.

Comment on attachment 646263 [details] [diff] [review] patch for default resolution bash-3.2# /usr/local/bin/screenresolution set 1600x1200x32 2012-07-26 12:50:52.245 screenresolution[1012:707] starting screenresolution argv=/usr/local/bin/screenresolution set 1600x1200x32 2012-07-26 12:50:52.250 screenresolution[1012:707] Error: the mode '1600x1200x32' couldn't be parsed I don't think the resolution is the problem. I think the problem is the missing refresh rate.

fix for this as well as a running tidy to clean up active state on Darwin

Comment on attachment 646298 [details] [diff] [review] patch I'm not generally a fan of piggybacking unrelated changes together, but I'll let it slide this time ;)

Fixed #2