Boris Zbarsky [:bzbarsky] Assignee
	Description • 12 years ago

Otherwise we can end up with the class declared before its members, and all is bad.

	Kyle Huey (Exited; not receiving bugmail, old account, do not use)
	Comment 2 • 12 years ago

Comment on attachment 645830 [details] [diff] [review]
Make sure our C++ declarations are in the right order when a dictionary has a dictionary member.

Review of attachment 645830 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Codegen.py
@@ +4041,5 @@
>      def __init__(self, dictionary, descriptorProvider):
>          self.dictionary = dictionary;
>          self.workers = descriptorProvider.workers
> +        if all(CGDictionary(d, descriptorProvider).generatable for
> +               d in self.getDictionaryDependencies(dictionary)):

Don't invoke static methods as self.getDictionaryDependencies().  Either make it non-static or invoke it as CGDictionary.getDictionaryDependencies.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 3 • 12 years ago

Fixed that, and http://hg.mozilla.org/integration/mozilla-inbound/rev/1571f03f3821

	Ed Morley [:emorley]
	Comment 4 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/1571f03f3821