Closed Bug 784223 Opened 12 years ago Closed 12 years ago

1 of 3 tests passing for page-worker on Fennec

Categories

(Add-on SDK Graveyard :: General, defect, P1)

All
Android
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: evold, Assigned: evold)

References

Details

Attachments

(1 file)

https://addons.mozilla.org/en-US/developers/docs/sdk/latest/dev-guide/tutorials/mobile.html says that page-worker is supported and I get 1 of 3 tests passing on master.
Some modules listed in the docs have the test that doesn't pass – see `page-mod` – because some dependencies (see `tabs`) in tests, but they were test manually. It could be also that something is changed in Fennec and/or page-worker since we documented the module: what are the tests that are failing?
Depends on: 793055
No longer depends on: 793055
Attachment #672372 - Flags: review? → review?(zer0)
Assignee: nobody → evold
It looks like page-workers never worked on Fennec :(
Hey Erik, as I mentioned to you on vydeo last week I reviewed this bug; there are some minor stuff, let me know if they makes sense to you or not so we could proceed with landing! :)
Flags: needinfo?(evold)
alright I've updated the pull request, and it's ready for another look
Flags: needinfo?(evold)
Matteo, can you review this one again? I think I've made all changes requested.
Attachment #672372 - Flags: review?(zer0) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: