Closed
Bug 784223
Opened 12 years ago
Closed 12 years ago
1 of 3 tests passing for page-worker on Fennec
Categories
(Add-on SDK Graveyard :: General, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evold, Assigned: evold)
References
Details
Attachments
(1 file)
https://addons.mozilla.org/en-US/developers/docs/sdk/latest/dev-guide/tutorials/mobile.html says that page-worker is supported and I get 1 of 3 tests passing on master.
Priority: -- → P1
Comment 1•12 years ago
|
||
Some modules listed in the docs have the test that doesn't pass – see `page-mod` – because some dependencies (see `tabs`) in tests, but they were test manually. It could be also that something is changed in Fennec and/or page-worker since we documented the module: what are the tests that are failing?
Assignee | ||
Updated•12 years ago
|
Blocks: sdk-on-fennec
Assignee | ||
Comment 2•12 years ago
|
||
Ah it appears that page worker does not work on Fennec at all https://github.com/mozilla/addon-sdk/blob/master/packages/addon-kit/lib/page-worker.js#L15
Assignee | ||
Comment 3•12 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•12 years ago
|
Attachment #672372 -
Flags: review?
Assignee | ||
Updated•12 years ago
|
Attachment #672372 -
Flags: review? → review?(zer0)
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → evold
Assignee | ||
Comment 4•12 years ago
|
||
It looks like page-workers never worked on Fennec :(
Comment 5•12 years ago
|
||
Hey Erik, as I mentioned to you on vydeo last week I reviewed this bug; there are some minor stuff, let me know if they makes sense to you or not so we could proceed with landing! :)
Flags: needinfo?(evold)
Assignee | ||
Comment 6•12 years ago
|
||
alright I've updated the pull request, and it's ready for another look
Flags: needinfo?(evold)
Assignee | ||
Comment 7•12 years ago
|
||
Matteo, can you review this one again? I think I've made all changes requested.
Updated•12 years ago
|
Attachment #672372 -
Flags: review?(zer0) → review+
Comment 8•12 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/8bbe2da12f5ae001ac601527cf2f5cfd0a75622d
Bug 784223 - page-worker supports Fennec
https://github.com/mozilla/addon-sdk/commit/45110cd76857354e77f5a37dbb743c8d10f76f20
Merge pull request #617 from erikvold/784223
Fix Bug 784223 - page-worker supports Fennec r=ZER0
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•