Closed
Bug 804187
Opened 12 years ago
Closed 12 years ago
Skip unsupported tests on Fennec until the proper implementation
Categories
(Add-on SDK Graveyard :: General, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zer0, Assigned: zer0)
References
Details
Attachments
(1 file)
When we execute unit test on Fennec, we should not raise an exception for unsupported modules, and skip them.
For a possible solution, see:
https://github.com/mozilla/addon-sdk/blob/master/test/test-selection.js#L443-457
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → zer0
Priority: -- → P1
|
|
Assignee | |
Updated•12 years ago
|
No longer depends on: 803065
Summary: Ensure unsupported modules on Fennec won't throw exceptions during tests → Skip unsupported tests on Fennec until the proper implementation
|
|
Assignee | |
Comment 1•12 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Updated•12 years ago
|
Attachment #679170 -
Flags: review?(rFobic)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 679170 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/652
Assigning to Erik, he should know ins & outs of mobile better. Looks good to me though.
Attachment #679170 -
Flags: review?(rFobic)
Attachment #679170 -
Flags: review?(evold)
Attachment #679170 -
Flags: feedback+
|
||
Comment 3•12 years ago
|
||
Comment on attachment 679170 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/652
just a couple minor things to change first mentioned in the pr
Attachment #679170 -
Flags: review?(evold) → review+
|
||
Comment 4•12 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/53bdff4c313bdd588c032606135889c0b8605d32
Merge pull request #652 from ZER0/fennec-tests/804187
Fix Bug 804187 - Skip unsupported tests on Fennec until the proper implementation r=@erikvold
|
|
||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•