Closed
Bug 791682
Opened 12 years ago
Closed 12 years ago
Hal's sSystemTimeObserver should be called sSystemTimeObservers
Categories
(Core :: Hardware Abstraction Layer (HAL), defect)
Core
Hardware Abstraction Layer (HAL)
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: justin.lebar+bug, Assigned: slee)
References
Details
Attachments
(1 file)
(deleted),
patch
|
justin.lebar+bug
:
review+
|
Details | Diff | Splinter Review |
static StaticAutoPtr<ObserverList<SystemTimeChange> > sSystemTimeObserver;
sSystemTimeObserver is a list of SystemTimeChange observers. Therefore it should be called sSystemTimeObservers. This would match the other globals scattered through Hal.cpp.
Steven, are you up for making this change, or would you prefer that I take care of it? Not a big deal either way.
Assignee | ||
Updated•12 years ago
|
QA Contact: slee
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → slee
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #661810 -
Flags: review?(justin.lebar+bug)
Reporter | ||
Updated•12 years ago
|
Attachment #661810 -
Flags: review?(justin.lebar+bug) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Reporter | ||
Comment 3•12 years ago
|
||
Thanks for the quick patch.
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c1a23434d79
Reporter | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•