Closed Bug 791962 Opened 12 years ago Closed 12 years ago

Time API: Clean up the usage comment in nsIDOMTimeManager (s/seconds/milliseconds)

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla18

People

(Reporter: airpingu, Assigned: airpingu)

References

Details

Attachments

(1 file, 3 obsolete files)

Patch 1.3
(deleted), patch
airpingu
: review+
Details | Diff | Splinter Review
This is a super minor fix but the comments could be confusing to public clients.
Sorry guys... It seems it's not a good idea to use cloning bug. I'll watch out next time.
Assignee: nobody → clian
Blocks: 714358
No longer blocks: webapi, b2g-system-time, 714357, 714362, b2g-product-phone, 789973, 790499, 285615, 714359, alarm-api, 790497
blocking-basecamp: + → ---
blocking-kilimanjaro: + → ---
No longer depends on: 791652, 791682, 714358, 790781, 790823, 791567
Keywords: dev-doc-needed, feature
Priority: P1 → --
Whiteboard: [WebAPI:P1]
Attached patch Patch (obsolete) (deleted) — — Splinter Review
Just a minor nit but we need to correct that. Clients could wrongly use that and then the world will explode.
Attachment #662075 - Flags: review?(mounir)
Attached patch Patch 1.1 (obsolete) (deleted) — — Splinter Review
Striping out the trailing spaces as well.
Attachment #662075 - Attachment is obsolete: true
Attachment #662075 - Flags: review?(mounir)
Attachment #662078 - Flags: review?(mounir)
Comment on attachment 662078 [details] [diff] [review] Patch 1.1 Review of attachment 662078 [details] [diff] [review]: ----------------------------------------------------------------- rs=me
Attachment #662078 - Flags: review?(mounir) → review+
Attached patch Patch 1.2 (obsolete) (deleted) — — Splinter Review
sr=mounir
Attachment #662078 - Attachment is obsolete: true
Attachment #662139 - Flags: review+
Keywords: checkin-needed
Actually, Gene, I should have been more explicit about what "rs+" means. It doesn't mean "sr+" but "rubber stamp" which basically means "this change doesn't need a proper review but I approve it so it can land". You can consider this as "r+". We mostly use that for typo fixes, comment changes, etc. where review doesn't make sense but having someone double-checking has to be part of the process.
Could you update the patch so the comment line doesn't mention sr but rs or r? Sorry again for the confusion.
Keywords: checkin-needed
Attached patch Patch 1.3 (deleted) — — Splinter Review
rs=mounir Thanks for pointing this out! Good to learn that. :)
Attachment #662139 - Attachment is obsolete: true
Attachment #662154 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cd720de0b57e
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: