Closed
Bug 791910
Opened 12 years ago
Closed 12 years ago
Wifi: Dying message managers don't get correctly unregistered
Categories
(Core :: DOM: Device Interfaces, defect)
Core
DOM: Device Interfaces
Tracking
()
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
cjones
:
review+
mrbkap
:
checkin+
|
Details | Diff | Splinter Review |
Currently, we have code in the DOM wifi manager that is supposed to tell the parent process when it's going away. Apparently, by the time we get notified that our process is dying, we aren't able to send messages anymore. That means that the steps (with a clean config):
* start the settings app
* close the settings app
* reopen the settings app and connect to a network
doesn't show any UI when we connect to the network since we end up trying to send a notification message to a message manager that has been torn down. bug 777200 provides a mechanism for fixing this, but in the meantime, we'll have to hack around it.
Assignee | ||
Comment 1•12 years ago
|
||
I want to check this in to fix the symptom and fix the underlying problem later.
Attachment #662005 -
Flags: review?(jones.chris.g)
Assignee | ||
Updated•12 years ago
|
blocking-basecamp: --- → ?
Assignee | ||
Updated•12 years ago
|
Summary: Dying message managers don't get correctly unregistered → Wifi: Dying message managers don't get correctly unregistered
Does this actually hack around that bug? What code will remove the mm? Do we keep sending failed messages to it forever?
Assignee | ||
Comment 3•12 years ago
|
||
This removes dead managers at the same time.
Attachment #662005 -
Attachment is obsolete: true
Attachment #662005 -
Flags: review?(jones.chris.g)
Attachment #662343 -
Flags: review?(jones.chris.g)
Comment on attachment 662343 [details] [diff] [review]
better hack
This patch really puts the "Java" into "JavaScript". At least you used a closure ;).
Attachment #662343 -
Flags: review?(jones.chris.g) → review+
Updated•12 years ago
|
blocking-basecamp: ? → +
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 662343 [details] [diff] [review]
better hack
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff173f012715
Attachment #662343 -
Flags: checkin+
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•