Closed
Bug 791911
Opened 12 years ago
Closed 12 years ago
Wifi: Dying message managers don't get correctly unregistered (real fix)
Categories
(Core :: DOM: Device Interfaces, defect)
Core
DOM: Device Interfaces
Tracking
()
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
Attachments
(1 file)
(deleted),
patch
|
gwagner
:
review+
mrbkap
:
checkin+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #791910 +++
This bug tracks the work needed to fix the real bug instead of wallpapering over it.
Comment 1•12 years ago
|
||
We can ship with the workaround from bug 791910 so blocking-.
blocking-basecamp: ? → -
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → mrbkap
Assignee | ||
Comment 2•12 years ago
|
||
Note the comment about the ordering of child-process-shutdown and the permissions check!
Attachment #667172 -
Flags: review?(anygregor)
Comment 3•12 years ago
|
||
Comment on attachment 667172 [details] [diff] [review]
Proposed fix
> });
> },
>
>@@ -2013,12 +2008,24 @@ WifiWorker.prototype = {
> },
>
> receiveMessage: function MessageManager_receiveMessage(aMessage) {
>- if (!aMessage.target.assertPermission("wifi-manage")) {
>+ let msg = aMessage.json || {};
can you do aMessage.data?
Next time more line-context please :)
Attachment #667172 -
Flags: review?(anygregor) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Comment on attachment 667172 [details] [diff] [review]
Proposed fix
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d5ac783d657 (with json -> data).
Attachment #667172 -
Flags: checkin+
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•