Closed Bug 794736 Opened 12 years ago Closed 7 years ago

Two master password popup windows come up

Categories

(Firefox :: Security, defect)

Product:
Firefox
Component:
Security
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 177175

People

(Reporter: bobbyalexphilip, Unassigned)

Details

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0.1
Build ID: 20120905151427

Steps to reproduce:

Preconditions-
      Have a master password set to remember passwords.
      Have firefox remember password for a site like GMail
Steps
     1) Open firefox window
     2) Open the GMail login page


Actual results:

    "Enter your password" popup comes up
    A couple of seconds later, another  "Enter your password" popup comes up in front of the earlier one, while typing the password
    Login will happen as normal



Expected results:

Only one popup should come.
I had raised and closed a similar bug earlier (https://bugzilla.mozilla.org/show_bug.cgi?id=751036) I am able to reproduce this consistently now using the steps above mentioned.
 I would guess the behaviour is related to the master password popup coming up even if, I don't navigate to a password protected site. I am thinking that when i open a password protected site like GMail, the general popup comes up, and while I am typing the password a popup triggered by navigating to GMail also comes up. This results in not so good User Experience as the focus goes to the new popup and generally the password entries gets screwed up
Bug 513534 looks to be a similar bug. The bugs are different but if the approach suggested in  https://bugzilla.mozilla.org/show_bug.cgi?id=513534#c3 is used, the fix should be the same
Group: privacy
Component: Untriaged → General
Product: Firefox → Privacy
Version: 15 Branch → unspecified
Group: privacy
Product: Privacy → Firefox
I see multiple master password prompts all the time if Firefox opens and loads multiple tabs to pages with stored passwords.  The way I got around this issue was to tell Firefox not to load a tab's page until I clicked on the tab via the option "don't load tab until selected".

It is kind of annoying to get multiple master password prompts.
Status: UNCONFIRMED → NEW
Component: General → Security
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86 → All
Version: unspecified → Trunk
Old bug but still there.
Since the browser is used more and more..

This is quite an important one to fix. It breaks nothing but it frustates people. Usability is important and this one is a real annoying usability breaker.

EVERY time you start firefox you have to type in you password several times...

This is what makes it userunfriendly.
- Start firefox
- Start typing something in a search engine... oh wait, the first 3 letters are in the search box but the others are in de master password box. (that is annoying to begin with)
- Remove letters from master password box
- Type you password
- Firefox was opening tabs in the background. Another master password box pop-up is shown. Again, half the characters are typed in the first pop-up, the other half in the second.

Solution is simple:
If someone has a master password, let them type it in BEFORE you can start browsing. That way even favourites and history are protected.
Because I always have to type my master password anyway when i'm browising but at unconvenient times.
Hey, I would like to give this bug fix a shot.
(In reply to Tim from comment #5)
> Hey, I would like to give this bug fix a shot.

Can't wait :-)
Thanks!
(In reply to Ronald from comment #6)
> (In reply to Tim from comment #5)
> > Hey, I would like to give this bug fix a shot.
> 
> Can't wait :-)
> Thanks!

Could you give me a little bit more info about how to recreate this bug?  When I open firefox typically only one window opens.  Then I enter let's say gmail, type in the master password, and all is well.  No second master password prompt ever.  Is there something I'm missing?

Thanks
One way to get it, a bit forced:
If you start your browser with gmail as your homepage. While opening you open a new tab (because you do not need gmail at this moment) an start typing in the address bar.

It also happens a lot when you have selected that you want al windows and tabs re-opened that were open when you closed Firefox an one of them is something with a login.

Also, when you do not visit sites that require a login and you are surfing, the password prompt shows up at any time.

I, personally would not mind that, when a masterpassword is set, the browser always shows the prompt before starting. That way the whole browser is protected (history and all).
But that would be a feature request i guess?
What version of firefox are you using on what operating system?

I ask because I'm not able to reproduce this error at all using the latest version on windows 10.  In this instance firefox pauses and doesn't let me continue until I enter my password, avoiding all of the errors you seem to be having.
The behaviour is the same on any OS. Even on Ubuntu.

It are actually two behaviours:
1)
The problem is that while you are typing in Google, addressbar, form, the browser suddenly thinks you should type in the password for whatever reason, you suddenly are typing in the password prompt. of course filling it with wrong characters and then you hit enter...(not always looking at the screen when typing blind)
So what you tested is correct but you were typing somewere else and forced to type your password at an inconvenient time and not always noticed when not looking at the screen while typing.

2)
If you start the browser with a few open tabs that require a password, the password box is shown more than one time. So you are typing in the box, a new empty password box pops over the current one and the rest of you password is typed in the new box. Of course you type enter (i type fast) resulting in the wrong password entered and thus a new password box pops up.

It is difficult to test. While you are testing you are expecting a result and thus acting like it.

I would suggest: Set your browser in a way that he opens all tabs that were open when closing the browser and start using it.

But entering the password before the browser will start would be the better solution imho.
When someone sets the password, they want security.
Ronald,

Let me ask again, what version of firefox are you using?  

As of this moment, version 45 release and version 48 nightly do not show this behavior.  In fact they both show behavior contrary to your post.  In this case, when one loads a website that prompts a master password, the prompt appears immediately and prevents any further i/o.  This prevents any attempt of loading a second master password prompt, or allowing one to half type in a form and half in the master password box.  

As for starting firefox with multiple tabs open, all other tabs are paused until the first master prompt is satisfied.  

All I can suggest is letting me know what versions of software you are using and updating to the most current version which, I believe, arrives today.

If that still doesn't work, then this may be an issue unique to your  OS and not across all versions like you suggested.
Ah, that is why you needed the version. Already working on a fix :-)

I updated and noticed that indeed the problem with the multiple password prompts is solved.

I did get the password prompt while typing in the address bar and that resulted in me typing stuff in the password field and hit enter (thus entering a wrong password)
A minor anoying thing.

If the password prompt would only show up when the tab that needs a password is active, that would solve that.

The current solution is a big improvement already! Thanks.
Don't thank me.  Someone else got to it first, as I was never able to reproduce the bug.

Unfortunately the second issue won't ever be fixed as i/o is inherently asynchronous.  My only suggestion is to wait a few seconds when you know the master password box will appear.
I was getting duplicate prompts until a week or two ago with Firefox Nightly, but the behavior has changed in the past week or so. I may still get duplicate prompts if I wait long enough but I haven't seen it for a few days.

There also appears to have been a change in when the password prompts appears (it shows up later), but I can't tell whether that is a Nightly change or a change in the behavior in the web sites in my pinned tabs.

There are three bugs on this issue. I'll let someone else decide which should be marked as duplicate.

Bug 794736: Firefox/Security: Two master password popup windows come up
Bug 981579: Toolkit/Password Manager: Asked for master password twice
Bug 1176399: MainNews Core/Networking: Multiple requests for master password when GMail OAuth2 is enabled
(In reply to B.J. Herbison from comment #14)
> There are three bugs on this issue. I'll let someone else decide which
> should be marked as duplicate.
> 
> Bug 794736: Firefox/Security: Two master password popup windows come up
> Bug 981579: Toolkit/Password Manager: Asked for master password twice
> Bug 1176399: MainNews Core/Networking: Multiple requests for master password
> when GMail OAuth2 is enabled

Don't forget Bug 177175: Should not display more than one "Master Password" prompts...
The problem still exists. This morning starting Nightly I received two prompts a few seconds after start-up.

For the past three weeks I've only seen one, even waiting much longer than this morning. The saved tabs at startup are identical to what I've been using for months. But, again, I have no idea whether the change in behavior is from Firefox or from the saved tabs.

The only tab I have preserved with a persistent login is Google Calendar, and Google (GMail) was identified as a trigger in at least this bug and bug 1176399.
This would be the ultimate fix and adds security:

I, personally would not mind that, when a masterpassword is set, the browser always shows the prompt before starting. That way the whole browser is protected (history and all).
But that would be a feature request i guess?
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.