Closed
Bug 794772
Opened 12 years ago
Closed 10 years ago
Port |Bug 713802 - Build with GIO support (and drop GnomeVFS)|
Categories
(SeaMonkey :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.31
People
(Reporter: InvisibleSmiley, Assigned: ewong)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
ewong
:
review+
|
Details | Diff | Splinter Review |
Bug 713802 just landed on mozilla-inbound (m-c will follow soon). We need to port this (esp. the gnomevfs removal) to stay in sync.
Comment 1•12 years ago
|
||
Don't we have a dependency on GnomeVFS in our GNOME shell service?
http://mxr.mozilla.org/comm-central/search?string=nsIGnomeVFSService.h
perhaps we don't actually use it.
Comment 2•12 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1348801551.1348801708.16537.gz#err0
checking MOZ_PANGO_LIBS... -L/lib -lpangoft2-1.0 -lpangocairo-1.0 -lpango-1.0 -lcairo -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0
checking for gtk+-2.0 >= 2.14... configure: error: * * * Could not find gtk+-2.0 > 2.14. Required for build with gio.
configure: error: /builds/slave/comm-cen-trunk-lnx-dbg/build/mozilla/configure failed for mozilla
Reporter | ||
Comment 3•12 years ago
|
||
(In reply to Philip Chee from comment #2)
> http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1348801551.1348801708.
> 16537.gz#err0
> checking MOZ_PANGO_LIBS... -L/lib -lpangoft2-1.0 -lpangocairo-1.0
> -lpango-1.0 -lcairo -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0
> checking for gtk+-2.0 >= 2.14... configure: error: * * * Could not find
> gtk+-2.0 > 2.14. Required for build with gio.
Hmm, I thought bug 794285 restored the ability to build with GTK 2.10? Was the build you referred to started before the checkin for bug 794285?
Comment 4•12 years ago
|
||
> Hmm, I thought bug 794285 restored the ability to build with GTK 2.10? Was the build
> you referred to started before the checkin for bug 794285?
See TB patch:
http://hg.mozilla.org/comm-central/rev/43533642df86
"Temporarily force-enable gnomevfs and disable gio until our Linux builders are upgraded (bug 794378) due to bug 713802 landing in mozilla-central. r=bustage-fix for CLOSED TREE"
Reporter | ||
Comment 5•12 years ago
|
||
A second changeset (modifying configure.in) was pushed for the base bug:
http://hg.mozilla.org/mozilla-central/rev/157f3efdee37
http://hg.mozilla.org/mozilla-central/rev/e520ade90abf
Also note dependent bug 795144:
http://hg.mozilla.org/mozilla-central/rev/358ade692d25
http://hg.mozilla.org/mozilla-central/rev/1949b59f3d12
Maybe we should do all of that here.
Please note that I'll be offline until Thursday, so I cannot work on this meanwhile (and not attend the status meeting on Tuesday either).
Assignee | ||
Comment 6•12 years ago
|
||
As well those mentioned in comment 5 there is also the configure.in changes from the following:
bug 805202 - http://hg.mozilla.org/mozilla-central/diff/a4e9d21b8ca8/configure.in
bug 467168 - http://hg.mozilla.org/mozilla-central/diff/78ed4ddb5fbd/configure.in
bug 402892 - http://hg.mozilla.org/mozilla-central/diff/2572312e17df/configure.in
Plus a few more if you do some digging.
Comment on attachment 704864 [details] [diff] [review]
Port patch (v1)
It is a start but more porting is needed I think.
Attachment #704864 -
Flags: feedback?(iann_bugzilla) → feedback-
Assignee | ||
Comment 9•11 years ago
|
||
Gone back to square one, so this bug will have to have someone else to give it love. I might retake this bug when I feel I have the brain cells to match the required skill. Until then, this is available for anyone to take.
Assignee: ewong → nobody
Status: ASSIGNED → NEW
Assignee | ||
Comment 10•10 years ago
|
||
Taking this up again :)
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Assignee | ||
Comment 11•10 years ago
|
||
Given the work from bug 846540, does this mean that we just need to
remove the --enable-gnomevfs from the mozconfigs and push the patch given
in this bug? (https://bugzilla.mozilla.org/attachment.cgi?id=704864) ?
As I understand it, all the GIO stuff is in mozilla/'s configure.in and if
I understand bug 846540, this means suite/ just needs the aforementioned patch?
Flags: needinfo?(Pidgeot18)
Comment 12•10 years ago
|
||
Comment on attachment 704864 [details] [diff] [review]
Port patch (v1)
>-MOZ_EXTENSIONS_DEFAULT=" venkman inspector irc gnomevfs"
>+MOZ_EXTENSIONS_DEFAULT=" venkman inspector irc gio"
Obviously without the venkman now.
r=me
Attachment #704864 -
Flags: feedback- → review+
Assignee | ||
Comment 13•10 years ago
|
||
(In reply to Ian Neal from comment #12)
> Comment on attachment 704864 [details] [diff] [review]
> Port patch (v1)
>
> >-MOZ_EXTENSIONS_DEFAULT=" venkman inspector irc gnomevfs"
> >+MOZ_EXTENSIONS_DEFAULT=" venkman inspector irc gio"
>
> Obviously without the venkman now.
> r=me
I'll update the patch.
Assignee | ||
Comment 14•10 years ago
|
||
Attachment #704864 -
Attachment is obsolete: true
Attachment #8466727 -
Flags: review+
Assignee | ||
Comment 15•10 years ago
|
||
Pushed to comm-central:
https://hg.mozilla.org/comm-central/rev/7b92fe9c3408
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.31
Updated•10 years ago
|
Flags: needinfo?(Pidgeot18)
You need to log in
before you can comment on or make changes to this bug.
Description
•