Closed Bug 795025 Opened 12 years ago Closed 12 years ago

update Unicode support to v6.2

Categories

(Core :: Internationalization, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: smontagu, Assigned: jfkthame)

References

()

Details

Attachments

(3 files, 3 obsolete files)

+++ This bug was initially created as a clone of Bug #723509 +++ We should update the various data tables, etc., that depend on Unicode, now that v6.2 is officially released. This mainly affects code/data under intl/, presumably, but also some in gfx/thebes/. Quite a lot has changed since the last update, so we should also confirm that https://wiki.mozilla.org/I18n:Updating_Unicode_version is up to date
Summary: update Unicode support to v6.1 → update Unicode support to v6.2
Attachment #668480 - Flags: review?(smontagu)
Attachment #668479 - Flags: review?(smontagu)
In principle, nsUnicodeRange is also affected, but I believe it's been way out-of-date for a long time anyway. We should just get rid of it and replace our dependencies on it with something new.
(as per bug 723045)
Comment on attachment 668479 [details] [diff] [review] update Unicode character property data to Unicode 6.2. Has this passed tryserver? I ask because I tried to patch this myself and there were all kinds of fail (https://tbpl.mozilla.org/?tree=Try&rev=1f8bc0df26dc).
Hmm, you're right - it produces an alarming amount of orange. :( Further investigation required...
Attachment #668479 - Flags: review?(smontagu)
Attachment #668480 - Flags: review?(smontagu)
Attachment #668479 - Attachment is obsolete: true
Attachment #668932 - Flags: review?(smontagu)
Attachment #668480 - Attachment is obsolete: true
Attachment #668931 - Attachment is obsolete: true
The problem was some refactoring of harfbuzz header files that has happened since last time we did this, which meant that the data-generation tool didn't find all the constants it was looking for - particularly for General Category, IIRC. I've fixed up the tool accordingly - and added checks so that it'll die with an appropriate message if/when this happens again, instead of giving us tables full of generic default properties. I think this should come back green now. (It looks much better locally, at least.) Tryserver run in progress at https://tbpl.mozilla.org/?tree=Try&rev=376bba3115b0.
Attachment #668929 - Flags: review?(smontagu) → review+
Attachment #668932 - Flags: review?(smontagu) → review+
Attachment #668930 - Flags: review?(smontagu) → review+
Depends on: 799602
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
The changes in this version were very minor (a grand total of one new character; no additions to things like case-conversion that would have visible effects for us). So I don't think test updates are needed. Our existing tests correctly showed us when the data-import process didn't work properly (as per comment #5 and following).
Flags: in-testsuite? → in-testsuite-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: