Closed
Bug 795174
Opened 12 years ago
Closed 12 years ago
Talos on Windows on Gecko 17 is busted trying to post to datazilla
Categories
(Release Engineering :: General, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philor, Unassigned)
Details
(Whiteboard: [datazilla])
Attachments
(2 files)
(deleted),
patch
|
mozilla
:
review+
nthomas
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jmaher
:
review-
|
Details | Diff | Splinter Review |
e.g.
https://tbpl.mozilla.org/php/getParsedLog.php?id=15608906&tree=Mozilla-Aurora
NOISE: Outputting datazilla results to https://datazilla.mozilla.org/talos
NOISE: datazilla: https//datazilla.mozilla.org/talos; oauth=True
Traceback (most recent call last):
File "run_tests.py", line 298, in ?
main()
File "run_tests.py", line 295, in main
run_tests(parser)
File "run_tests.py", line 271, in run_tests
talos_results.output(results_urls, **results_options)
File "c:\talos-slave\talos-data\talos\results.py", line 77, in output
_output.output(results, url)
File "c:\talos-slave\talos-data\talos\output.py", line 391, in output
self.post(results, results_server, results_path, results_scheme)
File "c:\talos-slave\talos-data\talos\output.py", line 472, in post
responses = req.submit()
File "c:\talos-slave\talos-data\talos\dzclient.py", line 194, in submit
responses.append(self.send(dataset))
File "c:\talos-slave\talos-data\talos\dzclient.py", line 225, in send
req = oauth.Request(method="POST", url=uri, parameters=params)
File "c:\talos-slave\talos-data\talos\oauth2\__init__.py", line 350, in __init__
v = to_unicode_optional_iterator(v)
File "c:\talos-slave\talos-data\talos\oauth2\__init__.py", line 135, in to_unicode_optional_iterator
assert 'is not iterable' in str(e)
AssertionError
program finished with exit code 1
Comment 1•12 years ago
|
||
Ok, so this is a rerun of bug 789972, and hurts on aurora because
http://hg.mozilla.org/releases/mozilla-aurora/file/default/testing/talos/talos.json
points at rev 38e088867f7b of talos, which is older than
hg.mozilla.org/build/talos/rev/399a75edf680l
which fixes this issue.
So the options are
A) ateam updates talos.json on aurora
B) releng disable datazilla on aurora until ateam has a chance to do 1
Comment 2•12 years ago
|
||
Updated•12 years ago
|
Attachment #665715 -
Flags: review?(aki) → review+
Comment 3•12 years ago
|
||
Comment on attachment 665715 [details] [diff] [review]
Disable datazilla on aurora
http://hg.mozilla.org/build/buildbot-configs/rev/cc96101408f4
Attachment #665715 -
Flags: checked-in+
Comment 4•12 years ago
|
||
Thanks for taking care of this, and sorry :(. I'll try to figure out why my staging run didn't fail like this.
Comment 5•12 years ago
|
||
I've reconfigured the masters to pick the patch up, and retried the failed jobs on aurora rev 6db116c397b1.
Over to jhammel to update the talos code, and then we can back out the config change.
Assignee: nthomas → jhammel
Comment 6•12 years ago
|
||
(In reply to Ben Hearsum [:bhearsum] from comment #4)
> Thanks for taking care of this, and sorry :(. I'll try to figure out why my
> staging run didn't fail like this.
Turns out that my final tests were only done on Linux, so I didn't catch this Windows-specific problem. My initial tests were on all platforms, but they were only done on mozilla-central. Thanks again for fixing this up folks.
Comment 7•12 years ago
|
||
Do we want to update the talos.json on aurora to point to the same talos.zip that m-c uses, or "other"?
Comment 8•12 years ago
|
||
Any talos.zip with the fix should be fine.
Comment 9•12 years ago
|
||
Attachment #666682 -
Flags: review?(jmaher)
Comment 10•12 years ago
|
||
Comment on attachment 666682 [details] [diff] [review]
point aurora to modern talos.zip
Review of attachment 666682 [details] [diff] [review]:
-----------------------------------------------------------------
I really don't like this idea. What have we changed since our last merge 5 weeks ago? We could regress numbers or break other things.
r- until we know what changed since the last uplift and can determine a risk assessment.
Attachment #666682 -
Flags: review?(jmaher) → review-
Comment 12•12 years ago
|
||
I guess we can wait until 18 merges to aurora and picks up the new datazilla.
Comment 13•12 years ago
|
||
is that next week?
Comment 14•12 years ago
|
||
Yeah. Monday/Tuesday
Updated•12 years ago
|
Summary: Talos on Windows on mozilla-aurora is busted trying to post to datazilla → Talos on Windows on Gecko 17 is busted trying to post to datazilla
Comment 16•12 years ago
|
||
did our uplift happen, is 17 on beta now and it is failing? Maybe we could push a hotfix to talos for 17 if this is still a problem for a specific branch.
Comment 17•12 years ago
|
||
We decided to wait for 18. See bug 794593.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
Assignee | ||
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•