c++ -o nsMessenger.o -c -I../../../mozilla/dist/stl_wrappers -I../../../mozilla/dist/system_wrappers -include /sources/comm-central/mozilla/config/gcc_hidden.h -DMOZ_LDAP_XPCOM -DMOZ_GLUE_IN_PROGRAM -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES -DMOZ_THUNDERBIRD=1 -DOSTYPE=\"Linux3.6\" -DOSARCH=Linux -DHAVE_MOVEMAIL -I/sources/comm-central/mailnews/base/src -I. -I../../../mozilla/dist/include -I../../../mozilla/dist/include/nsprpub `/home/ojab/opt/mail/mozilla/dist/sdk/bin/nspr-config --prefix=/home/ojab/opt/mail/mozilla/dist --includedir=/home/ojab/opt/mail/mozilla/dist/include/nspr --cflags` -I/home/ojab/opt/mail/mozilla/dist/include/nss -fPIC -pedantic -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Wtype-limits -Wempty-body -Wno-ctor-dtor-privacy -Wno-overlength-strings -Wno-invalid-offsetof -Wno-variadic-macros -Wcast-align -Wno-long-long -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -std=gnu++0x -pthread -pipe -DNDEBUG -DTRIMMED -g -Os -freorder-blocks -fomit-frame-pointer -DMOZILLA_CLIENT -include ../../../comm-config.h -MD -MF .deps/nsMessenger.pp /sources/comm-central/mailnews/base/src/nsMessenger.cpp /sources/comm-central/mailnews/base/src/nsMessenger.cpp: In member function ‘nsresult nsSaveMsgListener::InitializeDownload(nsIRequest*, uint32_t)’: /sources/comm-central/mailnews/base/src/nsMessenger.cpp:1726:57: error: no matching function for call to ‘nsITransfer::Init(nsCOMPtr<nsIURI>&, nsCOMPtr<nsIURI>&, const nsAFlatString&, nsCOMPtr<nsIMIMEInfo>&, PRTime&, NULL, nsSaveMsgListener* const)’ /sources/comm-central/mailnews/base/src/nsMessenger.cpp:1726:57: note: candidate is: In file included from /sources/comm-central/mailnews/base/src/nsMessenger.cpp:102:0: ../../../mozilla/dist/include/nsITransfer.h:39:14: note: virtual nsresult nsITransfer::Init(nsIURI*, nsIURI*, const nsAString_internal&, nsIMIMEInfo*, PRTime, nsIFile*, nsICancelable*, bool) ../../../mozilla/dist/include/nsITransfer.h:39:14: note: candidate expects 8 arguments, 7 provided make[8]: *** [nsMessenger.o] Error 1 make[8]: Leaving directory `/home/ojab/opt/mail/mailnews/base/src' make[7]: *** [src_libs] Error 2

The build bustage should be quite easy to fix - we just need to add an extra parameter to the call - which can be hard-coded as false as we don't support private browsing in Thunderbird. Looking at the changes here: http://hg.mozilla.org/mozilla-central/rev/eff426a003e1 We also need to port the addition of the parameter to saveURL (http://mxr.mozilla.org/comm-central/search?string=saveURL), most of which we should be able to get hints from the mozilla-central changeset. SeaMonkey may also need changes for addDownload and the download manager. I'm not working on this for at least a few hours, so anyone is welcome to take it.

(In reply to Mark Banner (:standard8) from comment #1) > I'm not working on this for at least a few hours, so anyone is welcome to > take it. (So assign it to yourself or comment on the bug if you are)

Patch allows me to continue building. Still needs someone to look at the other places mentioned in Comment 1.

Comment on attachment 667926 [details] [diff] [review] bustage fix, add missing parameter to nsITransfer::Init() [check-in comment 7] This is fine, but I'd prefer the saveURL to be fixed at the same time as this lands so that we don't miss it later.

(In reply to Mark Banner (:standard8) from comment #4) > This is fine, but I'd prefer the saveURL to be fixed at the same time as > this lands so that we don't miss it later. That's at least the mail/ part.

Sure. I'll let you decide whether to check-in the patch now or together with the remaining fixes.

Pushed part 1: http://hg.mozilla.org/comm-central/rev/3dc4ff7e8600

This passes the message window XUL document as the private-browsing context, rather than the actual email message document. This shouldn't matter, since we don't do private browsing at all.

Oops, missed the Aurora uplift with this one... https://hg.mozilla.org/comm-central/rev/0e346725f8e6

Comment on attachment 668138 [details] [diff] [review] Add missing parameters to saveURL [Approval Request Comment] Regression caused by (bug #): Bug 795065 User impact if declined: Save Link and Save Inline Image right-click actions don't work Testing completed (on c-c, etc.): Risk to taking this patch (and alternatives if risky): Low

Pushed to aurora: https://hg.mozilla.org/releases/comm-aurora/rev/1cdda6660ee7